From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25352C5B578 for ; Wed, 3 Jul 2019 22:08:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFDDC21882 for ; Wed, 3 Jul 2019 22:08:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UxSjmshB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727326AbfGCWIr (ORCPT ); Wed, 3 Jul 2019 18:08:47 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:43017 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727055AbfGCWIq (ORCPT ); Wed, 3 Jul 2019 18:08:46 -0400 Received: by mail-pf1-f193.google.com with SMTP id i189so1915131pfg.10 for ; Wed, 03 Jul 2019 15:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WjjWRdXySZkjpj26g1Pm4rzHQ2nCZawoM/TZfTFAezI=; b=UxSjmshB/efA5VRE78aPgnfuO/Sq/XiYw8vG5chnT45W8s9eIhSvPBCC/mGRdhQRAM aPD+zvMYLU6QJzAWBsTOmtbTqcGwnfwfDl1uFLrkBkjO6z7a5yH1SyE3GJ6Y5hBtDN+d XZAsuPc8zy95h9yxwn1SR3uls7dO9xvIAB3do= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WjjWRdXySZkjpj26g1Pm4rzHQ2nCZawoM/TZfTFAezI=; b=hlaVP1OeUfNyic6JKxnnqPDkZvguDCWcpHQIvM70d1ooKHfXYNI57hpXR1FZyqN0bR N5I7FJgCWZNPsWaJ404XTUJgdssqoBMrUxFzg+lYwnAwb4MqXn90BK0bspY0hQIoL6nt GwoZ/TvpFI8MJAQDCrJ9lvhf839ixTzJ41ftyKBmBSCzXQAiQlaTcNyfYiNb4FbUBahZ YTj7mNSHd0rcVktaIFIHOeG+AnHdVEJCKEICiO+kCIxDobJrdlYYloqrDrKgzwOa7yD6 VmyHkiUIFehSpp21RJ06DCcgx5r8E37dtQffM/rbGdqQ4wfLnLpSRvcDdKQYSgXhHN2y P5DA== X-Gm-Message-State: APjAAAWzX1OkDn65RoeuIwO2bLXwt63DMNvUDXtwtuIM760x5/dz3Zvh jGth/bpHNonmCkjc+v4Isy1AtQ== X-Google-Smtp-Source: APXvYqyNI7R7rRmSWaIP0fI91rk/hM1ha6x5voe4cvZVNb4VcCHs7IcJLnAucRtMAGfGWBsihbi9aw== X-Received: by 2002:a17:90b:8d8:: with SMTP id ds24mr15201077pjb.135.1562191725828; Wed, 03 Jul 2019 15:08:45 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id m16sm3360862pfd.127.2019.07.03.15.08.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jul 2019 15:08:45 -0700 (PDT) Date: Wed, 3 Jul 2019 15:08:43 -0700 From: Matthias Kaehlcke To: Andrew Lunn Cc: Rob Herring , "David S . Miller" , Mark Rutland , Florian Fainelli , Heiner Kallweit , netdev , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Douglas Anderson Subject: Re: [PATCH v2 1/7] dt-bindings: net: Add bindings for Realtek PHYs Message-ID: <20190703220843.GJ250418@google.com> References: <20190703193724.246854-1-mka@chromium.org> <20190703213327.GH18473@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190703213327.GH18473@lunn.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 03, 2019 at 11:33:27PM +0200, Andrew Lunn wrote: > > I think if we're going to have custom properties for phys, we should > > have a compatible string to at least validate whether the custom > > properties are even valid for the node. > > Hi Rob > > What happens with other enumerable busses where a compatible string is > not used? > > The Ethernet PHY subsystem will ignore the compatible string and load > the driver which fits the enumeration data. Using the compatible > string only to get the right YAML validator seems wrong. I would > prefer adding some other property with a clear name indicates its is > selecting the validator, and has nothing to do with loading the > correct driver. And it can then be used as well for USB and PCI > devices etc. I also have doubts whether a compatible string is the right answer here. It's not needed/used by the subsystem, but would it be a required property because it's needed for validation?