From: Greg KH <gregkh@linuxfoundation.org>
To: Yue Hu <zbestahu@gmail.com>
Cc: devel@driverdev.osuosl.org, yuchao0@huawei.com,
linux-kernel@vger.kernel.org, huyue2@yulong.com,
linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH RESEND v3] staging: erofs: remove unsupported ->datamode check in fill_inline_data()
Date: Thu, 4 Jul 2019 07:26:49 +0200 [thread overview]
Message-ID: <20190704052649.GA7454@kroah.com> (raw)
In-Reply-To: <20190704095903.0000565e.zbestahu@gmail.com>
On Thu, Jul 04, 2019 at 09:59:03AM +0800, Yue Hu wrote:
> On Wed, 3 Jul 2019 18:20:38 +0200
> Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > On Tue, Jul 02, 2019 at 10:56:01AM +0800, Yue Hu wrote:
> > > From: Yue Hu <huyue2@yulong.com>
> > >
> > > Already check if ->datamode is supported in read_inode(), no need to check
> > > again in the next fill_inline_data() only called by fill_inode().
> > >
> > > Signed-off-by: Yue Hu <huyue2@yulong.com>
> > > Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
> > > Reviewed-by: Chao Yu <yuchao0@huawei.com>
> > > ---
> > > no change
> > >
> > > drivers/staging/erofs/inode.c | 2 --
> > > 1 file changed, 2 deletions(-)
> >
> > This is already in my tree, right?
>
> Seems not, i have received notes about other 2 patches below mergerd:
>
> ```note1
> This is a note to let you know that I've just added the patch titled
>
> staging: erofs: don't check special inode layout
>
> to my staging git tree which can be found at
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> in the staging-next branch.
> ```
>
> ```note2
> This is a note to let you know that I've just added the patch titled
>
> staging: erofs: return the error value if fill_inline_data() fails
>
> to my staging git tree which can be found at
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> in the staging-next branch.
> ```
>
> No this patch in below link checked:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/log/drivers/staging/erofs?h=staging-testing
Then if it is not present, it needs to be rebased as it does not apply.
Please do so and resend it.
thanks,
greg k-h
next prev parent reply other threads:[~2019-07-04 5:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 2:56 [PATCH RESEND v3] staging: erofs: remove unsupported ->datamode check in fill_inline_data() Yue Hu
2019-07-03 16:20 ` Greg KH
2019-07-04 1:59 ` Yue Hu
2019-07-04 5:26 ` Greg KH [this message]
2019-07-04 10:02 ` Yue Hu
2019-07-04 10:31 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704052649.GA7454@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=huyue2@yulong.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox