From: Greg KH <gregkh@linuxfoundation.org>
To: Je Yen Tam <je.yen.tam@ni.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485 device IDs
Date: Thu, 4 Jul 2019 10:16:15 +0200 [thread overview]
Message-ID: <20190704081615.GB6438@kroah.com> (raw)
In-Reply-To: <MN2PR04MB5920BB86A99B1ABF946B2373B7FA0@MN2PR04MB5920.namprd04.prod.outlook.com>
On Thu, Jul 04, 2019 at 06:58:39AM +0000, Je Yen Tam wrote:
> > On Wed, Jul 03, 2019 at 12:25:16AM -0700, jeyentam wrote:
> > > Add NI PXIe-RS232, PXI-RS485 and PXIe-RS485 device IDs.
> > >
> > > Signed-off-by: jeyentam <je.yen.tam@ni.com>
> > > ---
> > > include/linux/pci_ids.h | 12 ++++++++++++
> > > 1 file changed, 12 insertions(+)
> >
> > You have read the comment at the top of this file, right? If so, why
> > are you adding these entries?
>
> Yes, but I think these entries should be added in because the NI-Serial PXI
> (RS232) device IDs already been defined in this file originally, so now I'm
> adding the newly supported NI-Serial PXI (RS485), PXIe (RS232) and PXIe
> (RS485) device IDs into here as they are the same product.
No, do not add new device ids to this file, only put them in the single
file that needs it. This file is for device ids that are shared across
multiple drivers/files.
You should not need to touch this file at all.
thanks,
greg k-h
next prev parent reply other threads:[~2019-07-04 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 7:25 [PATCH V2 2/2] PCI: Add NI-Serial PXI/PXIe+485 device IDs jeyentam
2019-07-03 8:36 ` Greg KH
2019-07-04 6:58 ` Je Yen Tam
2019-07-04 8:16 ` Greg KH [this message]
2019-07-04 8:17 ` Je Yen Tam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704081615.GB6438@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=je.yen.tam@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox