RE: linux-next: build failure after merge of the usb and usb-gadget trees

Pawel Laszczak
2019-07-04T08:07:29Z

>
>Hi,
>
>On Thu, Jul 4, 2019 at 9:59 AM Greg KH <greg@kroah.com> wrote:
>>
>> On Thu, Jul 04, 2019 at 04:34:58PM +1000, Stephen Rothwell wrote:
>> > Hi all,
>> >
>> > After merging the usb tree, today's linux-next build (arm
>> > multi_v7_defconfig) failed like this:
>> >
>> > arm-linux-gnueabi-ld: drivers/usb/dwc3/trace.o: in function `trace_raw_output_dwc3_log_ctrl':
>> > trace.c:(.text+0x119c): undefined reference to `usb_decode_ctrl'
>> >
>> > Caused by commit
>> >
>> > 3db1b636c07e ("usb:gadget Separated decoding functions from dwc3 driver.")
>> >
>> > I have used the usb tree from next-20190703 for today.
>> >
>> > This also occurs in the usb-gadget tree so I have used the version of
>> > that from next-20190703 as well.
>>
>> Odd, I thought I pulled the usb-gadget tree into mine. Felipe, can you
>> take a look at this to see if I messed something up?
>
>This looks like it was caused by Pawel's patches.
>
>I'll try to reproduce here and see what's causing it.

Problem is in my Patch. I reproduced it, but I don't understand why compiler
complains about usb_decode_ctrl. It's compiled into libcomposite.ko and
declaration is in drivers/usb/gadget.h.

>
>--
>balbi