From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C29C0C0650E for ; Thu, 4 Jul 2019 08:49:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C9AA2189E for ; Thu, 4 Jul 2019 08:49:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727253AbfGDIta (ORCPT ); Thu, 4 Jul 2019 04:49:30 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:32934 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726966AbfGDIta (ORCPT ); Thu, 4 Jul 2019 04:49:30 -0400 Received: by mail-wm1-f67.google.com with SMTP id h19so4763917wme.0 for ; Thu, 04 Jul 2019 01:49:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AB76fZ4FGkqviuGc5asXXE0TYmR4RcAuqGDgezPIa0I=; b=ZU8Fj2Jrw4YWurFur23fvyyU2f1a8d2VifHbyMN11tzBDpsO+bzXC3k8t1UCop5Lxc L2behfumsya6vv/XxB6CuzYtt/r6mY4SNxWb445KAFNysuNZ/jB9lAkS1dIurZ8LxZpW j2daElwIMYwAnM5Jpb6asEZy4ycRs30nTDBZ3xrIDiMoGmG9r+gwOio446OkqaQ07oPi VuvlRDxGSYYrPFtGxPv/ZoOXiZTpJTIlwQ1XF7ONwtG86vvBV313elNAs2UXoo4351M/ xQ0A2YBoE5fIUuK4kwPxTiFB3zA7iE4Y8NVWdMp/EceR5Aa+SjgqqtNOh/nMJ1YDqfot 25GQ== X-Gm-Message-State: APjAAAUrluv2h3b4mYpVbuiIvM5bnEzpg/SBNePwJS0iJaX3OblSGK5I ylp1886jtyko+PO5Xk/y3xdEyw== X-Google-Smtp-Source: APXvYqz1Q1DleGiXZJyelc0x4oeE2RpsSdPwidTtNcDiqfLPQI8czdr7RR9RMZcY1fHcuY/QWxxFUg== X-Received: by 2002:a1c:acc8:: with SMTP id v191mr11850426wme.177.1562230168039; Thu, 04 Jul 2019 01:49:28 -0700 (PDT) Received: from localhost.localdomain ([151.15.230.231]) by smtp.gmail.com with ESMTPSA id p11sm5493523wrm.53.2019.07.04.01.49.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Jul 2019 01:49:26 -0700 (PDT) Date: Thu, 4 Jul 2019 10:49:24 +0200 From: Juri Lelli To: Tejun Heo Cc: Peter Zijlstra , mingo@redhat.com, rostedt@goodmis.org, linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it, claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it, bristot@redhat.com, mathieu.poirier@linaro.org, lizefan@huawei.com, cgroups@vger.kernel.org, Prateek Sood Subject: Re: [PATCH v8 6/8] cgroup/cpuset: Change cpuset_rwsem and hotplug lock order Message-ID: <20190704084924.GC9099@localhost.localdomain> References: <20190628080618.522-1-juri.lelli@redhat.com> <20190628080618.522-7-juri.lelli@redhat.com> <20190628130308.GU3419@hirez.programming.kicks-ass.net> <20190701065233.GA26005@localhost.localdomain> <20190701082731.GP3402@hirez.programming.kicks-ass.net> <20190701145107.GY657710@devbig004.ftw2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190701145107.GY657710@devbig004.ftw2.facebook.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 01/07/19 07:51, Tejun Heo wrote: > Hello, > > On Mon, Jul 01, 2019 at 10:27:31AM +0200, Peter Zijlstra wrote: > > IIRC TJ figured it wasn't strictly required to fix the lock invertion at > > that time and they sorted it differently. If I (re)read the thread > > correctly the other day, he didn't have fundamental objections against > > it, but wanted the simpler fix. > > Yeah I've got no objections to the change itself, it just wasn't > needed at the time. We've had multiple issues there tho, so please > keep an eye open after the changes get merged. Should I take this as an indication that you had a look at the set and (apart from Peter's comments) you are OK with them? If that's the case I will send a v9 out soon. Otherwise I'd kindly ask you to please have a look. Thanks! Juri