public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Eckert <fe@dev.tdt.de>
To: Eckert.Florian@googlemail.com, info@metux.net,
	dvhart@infradead.org, andy@infradead.org
Cc: platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, Florian Eckert <fe@dev.tdt.de>
Subject: [PATCH 3/3] platform//x86/pcengines-apuv2: update gpio button definition
Date: Thu,  4 Jul 2019 11:02:05 +0200	[thread overview]
Message-ID: <20190704090205.19400-4-fe@dev.tdt.de> (raw)
In-Reply-To: <20190704090205.19400-1-fe@dev.tdt.de>

* Add the gpio number, so the button subsystem can find the right gpio.
* Change also the keycode from KEY_SETUP to KEY_RESTART, because it
  seems more expressive to me and in the Alix-Board, which is the
  predecessor, there isthis keycode defined too. I think this is also
  intended by Pcengines. Also many embedded systems defined in the kernel
  use this key code as well.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
---
 drivers/platform/x86/pcengines-apuv2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index d50a50e9d34c..370fd2686d59 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -116,7 +116,8 @@ struct gpiod_lookup_table gpios_led_table = {
 
 static struct gpio_keys_button apu2_keys_buttons[] = {
 	{
-		.code			= KEY_SETUP,
+		.code			= KEY_RESTART,
+		.gpio			= 508,
 		.active_low		= 1,
 		.desc			= "front button",
 		.type			= EV_KEY,
-- 
2.11.0


  parent reply	other threads:[~2019-07-04  9:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04  9:02 [PATCH 0/3] Update pcengines-apuv2 platform device Florian Eckert
2019-07-04  9:02 ` [PATCH 1/3] platform/x86/pcengines-apuv2: add mpcie reset gpio export Florian Eckert
2019-07-08 19:44   ` Enrico Weigelt, metux IT consult
2019-07-10 12:30     ` Florian Eckert
2019-07-15 12:15   ` Enrico Weigelt, metux IT consult
2019-07-15 14:38     ` Florian Eckert
2019-07-16 18:23       ` Enrico Weigelt, metux IT consult
2019-07-22 11:25   ` Enrico Weigelt, metux IT consult
2019-07-04  9:02 ` [PATCH 2/3] platform/x86/pcengines-apuv2: add legacy leds gpio definitions Florian Eckert
2019-07-08 19:42   ` Enrico Weigelt, metux IT consult
2019-07-10 12:03     ` Florian Eckert
2019-07-10 13:07       ` Enrico Weigelt, metux IT consult
2019-07-04  9:02 ` Florian Eckert [this message]
2019-07-08 19:27   ` [PATCH 3/3] platform//x86/pcengines-apuv2: update gpio button definition Enrico Weigelt, metux IT consult
2019-07-22 11:27   ` Enrico Weigelt, metux IT consult
2019-07-23  7:06     ` Florian Eckert
2019-07-23 23:00       ` Enrico Weigelt, metux IT consult
2019-07-04 13:39 ` [PATCH 0/3] Update pcengines-apuv2 platform device Andy Shevchenko
2019-07-04 14:00   ` Florian Eckert
2019-07-04 14:26     ` Andy Shevchenko
2019-07-05 11:36       ` Florian Eckert
2019-07-08 19:39         ` Enrico Weigelt, metux IT consult
2019-07-08 19:45   ` Enrico Weigelt, metux IT consult
2019-07-10 12:54     ` Florian Eckert
2019-07-25 17:49       ` Andy Shevchenko
2019-07-25 19:12         ` Enrico Weigelt, metux IT consult

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190704090205.19400-4-fe@dev.tdt.de \
    --to=fe@dev.tdt.de \
    --cc=Eckert.Florian@googlemail.com \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=info@metux.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox