From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67473C46484 for ; Thu, 4 Jul 2019 17:07:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BCA0218A0 for ; Thu, 4 Jul 2019 17:07:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="X6NiXeAM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727314AbfGDRHy (ORCPT ); Thu, 4 Jul 2019 13:07:54 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:37527 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727090AbfGDRHy (ORCPT ); Thu, 4 Jul 2019 13:07:54 -0400 Received: by mail-qt1-f196.google.com with SMTP id y57so6434762qtk.4 for ; Thu, 04 Jul 2019 10:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XqfKYWKGSYLgbJr6fPQ+lFHdBqt7mzzp7w7+/NgGtDk=; b=X6NiXeAMF1OwtlTW4QqugOJ53ZeaHYD/sLo9k8HcbCwSQByg/XZqvCY4YZ+NYEl7+p iNzSMGDWZ5tSIXvWCBaZgIICKztGnisde/lW/EA7/5qeHQu+15yWvVUsJRLIZmnz8wha FFQqyPZ2lh/7vbQ1YNZqInN11zwc/aPBlJbKnEheIYIs5DRlEPuNf2j32b7lU2Cr/rcQ 96vKhTR4yz256EpG20zwOf0ABEaIZ5Hm7+BC+Ly7ve2P51vGNgxR6r8d9luBnVSDGfnC hecuC40wXSVrpqNgLK4oewKcZuEQsgqJRuOyJclwZzjzgTs41CxzCm22YgsyxzVDu9Bi dJSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XqfKYWKGSYLgbJr6fPQ+lFHdBqt7mzzp7w7+/NgGtDk=; b=cmObNpR9s5WY2Jv2niZdR7ZHTY+QWD9Ofi2AMsQivyNmRlgjzCMz+VuAZ+2KgfsPJw XsEKlL3T0Kc+pkXC25CZ36wP2kvUZpLn6TNMisDJG6QZBcIoTHwMvaKikvQAtzrY75/A aBD92sBZ2kzeVZFIbHQfepMrDHQW3PY/cPrryu4sJkQHjb3F1kolKbhC17EP3UYLzK+b unVj3jK7bXn/oatyEfEcu1/VYoJj2KvY4VpSMUicJAX9L9gdoJt5+oYr7hNRP48vYB2n kHIHBAQRe9nZXakNkQ8nSYggzSkf1zMALMqNfb3ZOsGYsI5Z+/yvMChE0wKga8a6e/n/ m7PQ== X-Gm-Message-State: APjAAAV8YhNwVnt6b9V9ooazt2unvg8yikQfWk+zQOjkpjga3dgqczNk CvanaVChs5X4u8BYVHck1TUzuShMYIBMyA== X-Google-Smtp-Source: APXvYqxtr+v0L2/2WEquOomQKVdBZ8+LLKmCnbiOU43dpww5W7vo+SURvHo2eSQslH/YdnPX0elgpQ== X-Received: by 2002:aed:36c5:: with SMTP id f63mr36872490qtb.239.1562260073519; Thu, 04 Jul 2019 10:07:53 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id b67sm2660401qkd.82.2019.07.04.10.07.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Jul 2019 10:07:53 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hj5D6-000348-Ib; Thu, 04 Jul 2019 14:07:52 -0300 Date: Thu, 4 Jul 2019 14:07:52 -0300 From: Jason Gunthorpe To: Colin King Cc: Doug Ledford , linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] RDMA/uverbs: remove redundant assignment to variable ret Message-ID: <20190704170752.GA11760@ziepe.ca> References: <20190704125027.4514-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190704125027.4514-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 04, 2019 at 01:50:27PM +0100, Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized with a value that is never > read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/infiniband/core/uverbs_cmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next, thanks Jason