From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50E9CC46499 for ; Fri, 5 Jul 2019 20:10:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29CAC2133F for ; Fri, 5 Jul 2019 20:10:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727615AbfGEUKL (ORCPT ); Fri, 5 Jul 2019 16:10:11 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:36618 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbfGEUKK (ORCPT ); Fri, 5 Jul 2019 16:10:10 -0400 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23991965AbfGEUKHvIEHf (ORCPT ); Fri, 5 Jul 2019 22:10:07 +0200 Date: Fri, 5 Jul 2019 22:10:06 +0200 From: Ladislav Michl To: Hariprasad Kelam Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Vinod Koul , Gen Zhang , Dan Carpenter , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag Message-ID: <20190705201006.GA22085@lenoch> References: <20190704191026.GA20732@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190704191026.GA20732@hari-Inspiron-1545> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 05, 2019 at 12:40:26AM +0530, Hariprasad Kelam wrote: > Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq > handler finished". > > fixes below issue reported by coccicheck > > sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no > primary handler requested without IRQF_ONESHOT > > Signed-off-by: Hariprasad Kelam > --- > sound/soc/codecs/wcd9335.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c > index 85737fe..7ab9bf6f 100644 > --- a/sound/soc/codecs/wcd9335.c > +++ b/sound/soc/codecs/wcd9335.c > @@ -4056,6 +4056,9 @@ static struct wcd9335_irq wcd9335_irqs[] = { > static int wcd9335_setup_irqs(struct wcd9335_codec *wcd) > { > int irq, ret, i; > + unsigned long irqflags; > + > + irqflags = IRQF_TRIGGER_RISING | IRQF_ONESHOT; Why does this change trigger adding a variable? > for (i = 0; i < ARRAY_SIZE(wcd9335_irqs); i++) { > irq = regmap_irq_get_virq(wcd->irq_data, wcd9335_irqs[i].irq); > @@ -4067,7 +4070,7 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd) > > ret = devm_request_threaded_irq(wcd->dev, irq, NULL, > wcd9335_irqs[i].handler, > - IRQF_TRIGGER_RISING, > + irqflags, > wcd9335_irqs[i].name, wcd); > if (ret) { > dev_err(wcd->dev, "Failed to request %s\n", > -- > 2.7.4 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel