From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D40C5B578 for ; Sat, 6 Jul 2019 09:05:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A72521670 for ; Sat, 6 Jul 2019 09:05:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726039AbfGFJFc (ORCPT ); Sat, 6 Jul 2019 05:05:32 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:51896 "EHLO hera.aquilenet.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725934AbfGFJFc (ORCPT ); Sat, 6 Jul 2019 05:05:32 -0400 X-Greylist: delayed 308 seconds by postgrey-1.27 at vger.kernel.org; Sat, 06 Jul 2019 05:05:32 EDT Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 2ED7F6069; Sat, 6 Jul 2019 11:00:21 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4_8_IRcTvWRm; Sat, 6 Jul 2019 11:00:20 +0200 (CEST) Received: from function (dhcp-64-231.ens-lyon.fr [140.77.64.231]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 73E6A6063; Sat, 6 Jul 2019 11:00:20 +0200 (CEST) Received: from samy by function with local (Exim 4.92) (envelope-from ) id 1hjgYN-0004Wq-Jw; Sat, 06 Jul 2019 11:00:19 +0200 Date: Sat, 6 Jul 2019 11:00:19 +0200 From: Samuel Thibault To: Markus Elfring Cc: speakup@linux-speakup.org, devel@driverdev.osuosl.org, Bhagyashri Dighole , Chris Brannon , Greg Kroah-Hartman , Kirk Reiser , Okash Khawaja , William Hubbs , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] staging: speakup: One function call less in speakup_win_enable() Message-ID: <20190706090019.rivposzrqesodhso@function> Mail-Followup-To: Samuel Thibault , Markus Elfring , speakup@linux-speakup.org, devel@driverdev.osuosl.org, Bhagyashri Dighole , Chris Brannon , Greg Kroah-Hartman , Kirk Reiser , Okash Khawaja , William Hubbs , LKML , kernel-janitors@vger.kernel.org References: <11f79333-25c3-1ad9-4975-58c64821f3fe@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11f79333-25c3-1ad9-4975-58c64821f3fe@web.de> Organization: I am not organized User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Markus Elfring, le sam. 06 juil. 2019 10:15:30 +0200, a ecrit: > From: Markus Elfring > Date: Sat, 6 Jul 2019 10:03:56 +0200 > > Avoid an extra function call by using a ternary operator instead of > a conditional statement. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Reviewed-by: Samuel Thibault > --- > drivers/staging/speakup/main.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c > index 488f2539aa9a..03bbc9a4dbb3 100644 > --- a/drivers/staging/speakup/main.c > +++ b/drivers/staging/speakup/main.c > @@ -1917,10 +1917,9 @@ static void speakup_win_enable(struct vc_data *vc) > return; > } > win_enabled ^= 1; > - if (win_enabled) > - synth_printf("%s\n", spk_msg_get(MSG_WINDOW_SILENCED)); > - else > - synth_printf("%s\n", spk_msg_get(MSG_WINDOW_SILENCE_DISABLED)); > + synth_printf("%s\n", spk_msg_get(win_enabled > + ? MSG_WINDOW_SILENCED > + : MSG_WINDOW_SILENCE_DISABLED)); > } > > static void speakup_bits(struct vc_data *vc) > -- > 2.22.0 > -- Samuel --- christ gives channel operator status to Dieu -+- #ens-mim and hell -+-