From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CBEEC5B578 for ; Sat, 6 Jul 2019 09:29:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EED97216B7 for ; Sat, 6 Jul 2019 09:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562405361; bh=q0ChCYbw9BUDkWl5qTb6N9u6aCLW/OO4j39NqDScVdE=; h=Date:From:To:Subject:References:In-Reply-To:List-ID:From; b=naHBYaoUeWpsKEVTmrFKwtsp4/GqQLfOD5eo0QC/FwimUocPFBP1Qp0HdJ3tJ7R93 HGrFyFHs8os92SgJOzvLpVx7/IpOSo6SCxRZhgq9oIYVtN/gK83uxNAYeJqbRfGwS/ CXhnRk61LejmMWVegyXbXiYq1yHFv9wkeQGf38xo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726085AbfGFJ3T (ORCPT ); Sat, 6 Jul 2019 05:29:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:40536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725934AbfGFJ3T (ORCPT ); Sat, 6 Jul 2019 05:29:19 -0400 Received: from localhost (unknown [62.119.166.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE45220838; Sat, 6 Jul 2019 09:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562405358; bh=q0ChCYbw9BUDkWl5qTb6N9u6aCLW/OO4j39NqDScVdE=; h=Date:From:To:Subject:References:In-Reply-To:From; b=aamOu0XKXSBhtt1yKpU6r/ss1xC8nZzgJj4jyUslKR76f+Ra2rEh4O8h/yEl7rD6V ieQX+PHjtC9RbnIPPDP4hxoy0JuqaDIsgqW1m573K/ooKz9bzdHenhr65sRbFBEarR 0fihP89c8qhaBtcYn0lQlkZAGBnLZYdvNAQNBj6U= Date: Sat, 6 Jul 2019 11:28:56 +0200 From: Greg Kroah-Hartman To: Samuel Thibault , Markus Elfring , speakup@linux-speakup.org, devel@driverdev.osuosl.org, Bhagyashri Dighole , Chris Brannon , Kirk Reiser , Okash Khawaja , William Hubbs , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] staging: speakup: One function call less in speakup_win_enable() Message-ID: <20190706092856.GA15480@kroah.com> References: <11f79333-25c3-1ad9-4975-58c64821f3fe@web.de> <20190706090019.rivposzrqesodhso@function> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190706090019.rivposzrqesodhso@function> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 06, 2019 at 11:00:19AM +0200, Samuel Thibault wrote: > Markus Elfring, le sam. 06 juil. 2019 10:15:30 +0200, a ecrit: > > From: Markus Elfring > > Date: Sat, 6 Jul 2019 10:03:56 +0200 > > > > Avoid an extra function call by using a ternary operator instead of > > a conditional statement. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > Reviewed-by: Samuel Thibault Sorry, but this author/bot is in my kill-file and I no longer accept patches from them. And I HATE ternary operators anyway, so it's not like I would take this patch if it came from someone else :) thanks, greg k-h