Re: [PATCH v4 11/24] PM / devfreq: tegra30: Add debug messages

Chanwoo Choi
2019-07-16T12:21:00Z

Hi Dmitry,

Usually, the kernel log print for all users
such as changing the frequency, fail or success.

But, if the log just show the register dump,
it is not useful for all users. It is just used
for only specific developer.

I recommend that you better to add more exception handling
code on many points instead of just showing the register dump.

On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote:
> Add debug messages to know about what's happening in hardware and how
> driver reacts.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/devfreq/tegra30-devfreq.c | 35 +++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index 878c9396bb8c..c6c4a07d3e07 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -41,6 +41,7 @@
> #define ACTMON_DEV_AVG_UPPER_WMARK 0x10
> #define ACTMON_DEV_AVG_LOWER_WMARK 0x14
> #define ACTMON_DEV_COUNT_WEIGHT 0x18
> +#define ACTMON_DEV_COUNT 0x1c
> #define ACTMON_DEV_AVG_COUNT 0x20
> #define ACTMON_DEV_INTR_STATUS 0x24
>
> @@ -276,6 +277,9 @@ static void tegra_actmon_get_lower_upper(struct tegra_devfreq *tegra,
> unsigned long *lower,
> unsigned long *upper)
> {
> + struct device *ddev = tegra->devfreq->dev.parent;
> + u32 offset = dev->config->offset;
> +
> /*
> * Memory frequencies are guaranteed to have 1MHz granularity
> * and thus we need this rounding down to get a proper watermarks
> @@ -288,6 +292,9 @@ static void tegra_actmon_get_lower_upper(struct tegra_devfreq *tegra,
> *lower = tegra_actmon_lower_freq(tegra, target_freq);
> *upper = tegra_actmon_upper_freq(tegra, target_freq);
>
> + dev_dbg(ddev, "%03x: target_freq %lu lower freq %lu upper freq %lu\n",
> + offset, target_freq, *lower, *upper);
> +
> *lower /= KHZ;
> *upper /= KHZ;
>
> @@ -367,11 +374,31 @@ static void tegra_devfreq_update_wmark(struct tegra_devfreq *tegra,
> device_writel(dev, lower + delta, ACTMON_DEV_LOWER_WMARK);
> }
>
> +static void actmon_device_debug(struct tegra_devfreq *tegra,
> + struct tegra_devfreq_device *dev,
> + const char *prefix)
> +{
> + dev_dbg(tegra->devfreq->dev.parent,
> + "%03x: %s: 0x%08x 0x%08x a %u %u %u c %u %u %u b %lu cpu %u\n",
> + dev->config->offset, prefix,
> + device_readl(dev, ACTMON_DEV_INTR_STATUS),
> + device_readl(dev, ACTMON_DEV_CTRL),
> + device_readl(dev, ACTMON_DEV_AVG_COUNT),
> + device_readl(dev, ACTMON_DEV_AVG_LOWER_WMARK),
> + device_readl(dev, ACTMON_DEV_AVG_UPPER_WMARK),
> + device_readl(dev, ACTMON_DEV_COUNT),
> + device_readl(dev, ACTMON_DEV_LOWER_WMARK),
> + device_readl(dev, ACTMON_DEV_UPPER_WMARK),
> + dev->boost_freq, cpufreq_get(0));
> +}
> +
> static void actmon_isr_device(struct tegra_devfreq *tegra,
> struct tegra_devfreq_device *dev)
> {
> u32 intr_status, dev_ctrl, avg_intr_mask;
>
> + actmon_device_debug(tegra, dev, "isr+");
> +
> dev->avg_count = device_readl(dev, ACTMON_DEV_AVG_COUNT);
> intr_status = device_readl(dev, ACTMON_DEV_INTR_STATUS);
> dev_ctrl = device_readl(dev, ACTMON_DEV_CTRL);
> @@ -422,6 +449,8 @@ static void actmon_isr_device(struct tegra_devfreq *tegra,
>
> device_writel(dev, dev_ctrl, ACTMON_DEV_CTRL);
> device_writel(dev, ACTMON_INTR_STATUS_CLEAR, ACTMON_DEV_INTR_STATUS);
> +
> + actmon_device_debug(tegra, dev, "isr-");
> }
>
> static unsigned long actmon_update_target(struct tegra_devfreq *tegra,
> @@ -712,6 +741,7 @@ static struct devfreq_dev_profile tegra_devfreq_profile = {
> static int tegra_governor_get_target(struct devfreq *devfreq,
> unsigned long *freq)
> {
> + struct device *ddev = devfreq->dev.parent;
> struct devfreq_dev_status *stat;
> struct tegra_devfreq *tegra;
> struct tegra_devfreq_device *dev;
> @@ -734,6 +764,11 @@ static int tegra_governor_get_target(struct devfreq *devfreq,
> dev_target_freq = actmon_update_target(tegra, dev);
>
> target_freq = max(target_freq, dev_target_freq);
> +
> + dev_dbg(ddev, "%03x: upd: dev_target_freq %lu\n",
> + dev->config->offset, dev_target_freq);
> +
> + actmon_device_debug(tegra, dev, "upd");
> }
>
> *freq = target_freq * KHZ;
>

--
Best Regards,
Chanwoo Choi
Samsung Electronics