From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14FF2C606BA for ; Mon, 8 Jul 2019 14:07:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D56FA20665 for ; Mon, 8 Jul 2019 14:07:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ar7Kcqqv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731590AbfGHOH0 (ORCPT ); Mon, 8 Jul 2019 10:07:26 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:39170 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728827AbfGHOH0 (ORCPT ); Mon, 8 Jul 2019 10:07:26 -0400 Received: by mail-pg1-f193.google.com with SMTP id u17so7271642pgi.6 for ; Mon, 08 Jul 2019 07:07:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Mts5yXroYfI0Wyr9A7s3Gq+YGagV18S7ZKDUSCh+Ia4=; b=Ar7KcqqvFoS0ThSHwovLDA9qQWM2EJH3qjIpyKl3b4YnedviunpO7IQp89bVPTPzBk P+x6YNfU5ljERwWpQQyXdbBjojZsOcJiP3H04LVHviza9gaRb642lZkAp/urelJg+I72 Hx8P7Whuj18+wBXeysBAjp/aSXUklw0T295qs2lyX+tqmgRxNcShJOe0Dx4urKsesPdc 61cW3j13D4Lmbj6YO9aiIZrXQw0GEKmnxz/eEDhRGtVrr7XRiyYVcPpwnGNUt34WLs6V MSP2AM0ftxnTtHXp2Vks02n7FExxBXfQdIGKUXeILgz/8okYpn3KCgdHZ/IF+HthdlvD fBUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Mts5yXroYfI0Wyr9A7s3Gq+YGagV18S7ZKDUSCh+Ia4=; b=brWDFUq9tvAyee73mlJ5pf0LjDO4xsmT4lK/UE6C3CWFjRIfA+TQKGmG3CyLWDF31m 0tLPMTjetUqmFc0LvzKRKCkbn2QwUnq4lC3OrXxeo0tD0191P8b/wqu0oc7fTwLtkjv4 X5V9Y6VqhkZ/SrTEZjAK1XCDVbDWNnPJpU0tZiCOTJyn3a1nVg+uB4xn2Y8oEJKaWyp2 NrlB/RJQxygjoRuxpXi3sQfcmlrFCG09ERXdvj2+qMkJW1704ENVpHoYe7+eZp6yDwdM ECL8QoJCMy2NwB+9gQ3b9QTx+cCbDOi1x1UcT4F6Ixh/cR7z9oV4lTRwXvPe5a51qs8z ooXg== X-Gm-Message-State: APjAAAUxtxbmelWyvDob7WfRz1cD+/NHWKpUzHRtXVb5ctiaAWksmd3T /+9MrH9Fz0hZUSV56PMCRN9UuA== X-Google-Smtp-Source: APXvYqyOo/VR8k+Lrm9hsqwa/a1o/yTnfvlKDKvFiVcDf1Ab1otQGc7c6JYEVh/QTss3ainGobUAHw== X-Received: by 2002:a63:5920:: with SMTP id n32mr9668843pgb.352.1562594845697; Mon, 08 Jul 2019 07:07:25 -0700 (PDT) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id y133sm17699205pfb.28.2019.07.08.07.07.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jul 2019 07:07:24 -0700 (PDT) Date: Mon, 8 Jul 2019 07:07:22 -0700 From: Bjorn Andersson To: Arnd Bergmann Cc: Ohad Ben-Cohen , Maxime Coquelin , Alexandre Torgue , Fabien Dessenne , Ludovic Barre , Loic Pallardy , Arnaud Pouliquen , linux-remoteproc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: stm32: fix building without ARM SMCC Message-ID: <20190708140722.GI1263@builder> References: <20190708124311.3448056-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190708124311.3448056-1-arnd@arndb.de> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 08 Jul 05:42 PDT 2019, Arnd Bergmann wrote: > When compile testing this driver without SMCC support enabled, > we get a link error: > > drivers/remoteproc/stm32_rproc.o: In function `stm32_rproc_start': > stm32_rproc.c:(.text+0x776): undefined reference to `__arm_smccc_smc' > drivers/remoteproc/stm32_rproc.o: In function `stm32_rproc_stop': > stm32_rproc.c:(.text+0x92c): undefined reference to `__arm_smccc_smc' > > Make the actual call to arm_smccc_smc conditional on the Kconfig > symbol controlling its implementation. > > Fixes: 13140de09cc2 ("remoteproc: stm32: add an ST stm32_rproc driver") > Signed-off-by: Arnd Bergmann Thanks Arnd, applied Regards, Bjorn > --- > drivers/remoteproc/stm32_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index e83077b9ebf5..e2da7198b65f 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -344,7 +344,7 @@ static int stm32_rproc_set_hold_boot(struct rproc *rproc, bool hold) > > val = hold ? HOLD_BOOT : RELEASE_BOOT; > > - if (ddata->secured_soc) { > + if (IS_ENABLED(CONFIG_HAVE_ARM_SMCCC) && ddata->secured_soc) { > arm_smccc_smc(STM32_SMC_RCC, STM32_SMC_REG_WRITE, > hold_boot.reg, val, 0, 0, 0, 0, &smc_res); > err = smc_res.a0; > -- > 2.20.0 >