From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CA47C606C1 for ; Mon, 8 Jul 2019 15:44:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12AAA216E3 for ; Mon, 8 Jul 2019 15:44:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562600643; bh=mzbeTsKDy1cED57NDZNwyA+OUZJUbMKf/DQpwdW6/Uc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0ht7Fpf94KLvbdKqiU/hYpplrStdlL8nI6COKmBq7n4E7jmhksgJruBsWwg9YvC3i uOMDxqZQtSAnCVqal1GV/locxipLBhQVZxvjBwDKnyAE/Gz36AIuxC1IFVrdc/vGUl g/ZARZFuiMLlwL4UogkwEUmxFbIunI/IJACZqpKs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391193AbfGHPoC (ORCPT ); Mon, 8 Jul 2019 11:44:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:50792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388224AbfGHPXj (ORCPT ); Mon, 8 Jul 2019 11:23:39 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D1BD216C4; Mon, 8 Jul 2019 15:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562599418; bh=mzbeTsKDy1cED57NDZNwyA+OUZJUbMKf/DQpwdW6/Uc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uWUyxyFs95UTI5QrGDZKo08z67PWwwM5tldkIiaQF8ZBOg1ODN1WE3951pYQ2xvzA iGF9k5g4F/Ek3TUpa4r+lYvc2A68tCczTdiXmMVxEJISmPGKf75SFqnoRYZPZvA5/g 3P+AlmmN4rpUbiF3FnK6n8l8KyeKj0pAypsMEKp4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Matias Karhumaa , Marcel Holtmann , Linus Torvalds Subject: [PATCH 4.14 01/56] Bluetooth: Fix faulty expression for minimum encryption key size check Date: Mon, 8 Jul 2019 17:12:53 +0200 Message-Id: <20190708150516.876580590@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190708150514.376317156@linuxfoundation.org> References: <20190708150514.376317156@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matias Karhumaa commit eca94432934fe5f141d084f2e36ee2c0e614cc04 upstream. Fix minimum encryption key size check so that HCI_MIN_ENC_KEY_SIZE is also allowed as stated in the comment. This bug caused connection problems with devices having maximum encryption key size of 7 octets (56-bit). Fixes: 693cd8ce3f88 ("Bluetooth: Fix regression with minimum encryption key size alignment") Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203997 Signed-off-by: Matias Karhumaa Cc: stable@vger.kernel.org Signed-off-by: Marcel Holtmann Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- net/bluetooth/l2cap_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -1352,7 +1352,7 @@ static bool l2cap_check_enc_key_size(str * actually encrypted before enforcing a key size. */ return (!test_bit(HCI_CONN_ENCRYPT, &hcon->flags) || - hcon->enc_key_size > HCI_MIN_ENC_KEY_SIZE); + hcon->enc_key_size >= HCI_MIN_ENC_KEY_SIZE); } static void l2cap_do_start(struct l2cap_chan *chan)