From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85200C606BD for ; Mon, 8 Jul 2019 15:27:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 521E72173E for ; Mon, 8 Jul 2019 15:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562599676; bh=mWMQHXqKZVR3al1nTYvxdRttsfifL0w1ICxxsQaXT3Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YMOWBe9B85afD7/CZDrH+PaytbeMRH5hACLG25H7VVS8UYizWTluGjDCfHXHHsE/6 H19O8kFdpZIzISm3TPlZICbUSMsiDL5WRN9FvEKTP+Yz5R0CxU3c9hvNM8t7zitQxR hRxbYkK2O7I5skRBw8xvleijz8Z3c3Jp3XQUGuB4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389180AbfGHP1z (ORCPT ); Mon, 8 Jul 2019 11:27:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:56214 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389165AbfGHP1w (ORCPT ); Mon, 8 Jul 2019 11:27:52 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7CA03216C4; Mon, 8 Jul 2019 15:27:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562599672; bh=mWMQHXqKZVR3al1nTYvxdRttsfifL0w1ICxxsQaXT3Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h4DRLGBK5yOVWvWmbwIcmQmywHL8IcKRWDSIl9eI6Lnz4XMK8KtqWmPjQ6xNlcqxp 9HRYj53UJ+CYvxW2mgsDuy6QOLrrJiBzcshh98HbDW1303Lu6CuMpRcuHsjm4gybMQ 84qTQTbhANvkAhs5QWwRBNBbyGgzmcIfi3UvyWzc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vasily Gorbik , "Steven Rostedt (VMware)" , Sasha Levin Subject: [PATCH 4.19 37/90] tracing: avoid build warning with HAVE_NOP_MCOUNT Date: Mon, 8 Jul 2019 17:13:04 +0200 Message-Id: <20190708150524.469699228@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190708150521.829733162@linuxfoundation.org> References: <20190708150521.829733162@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit cbdaeaf050b730ea02e9ab4ff844ce54d85dbe1d ] Selecting HAVE_NOP_MCOUNT enables -mnop-mcount (if gcc supports it) and sets CC_USING_NOP_MCOUNT. Reuse __is_defined (which is suitable for testing CC_USING_* defines) to avoid conditional compilation and fix the following gcc 9 warning on s390: kernel/trace/ftrace.c:2514:1: warning: ‘ftrace_code_disable’ defined but not used [-Wunused-function] Link: http://lkml.kernel.org/r/patch.git-1a82d13f33ac.your-ad-here.call-01559732716-ext-6629@work.hours Fixes: 2f4df0017baed ("tracing: Add -mcount-nop option support") Signed-off-by: Vasily Gorbik Signed-off-by: Steven Rostedt (VMware) Signed-off-by: Sasha Levin --- kernel/trace/ftrace.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 1688782f3dfb..90348b343460 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -2952,14 +2952,13 @@ static int ftrace_update_code(struct module *mod, struct ftrace_page *new_pgs) p = &pg->records[i]; p->flags = rec_flags; -#ifndef CC_USING_NOP_MCOUNT /* * Do the initial record conversion from mcount jump * to the NOP instructions. */ - if (!ftrace_code_disable(mod, p)) + if (!__is_defined(CC_USING_NOP_MCOUNT) && + !ftrace_code_disable(mod, p)) break; -#endif update_cnt++; } -- 2.20.1