From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888CCC606C1 for ; Mon, 8 Jul 2019 15:35:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6197F20651 for ; Mon, 8 Jul 2019 15:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562600119; bh=TSKGw1r5dLtQbJRCdmKWf5HSmP9FklzelECTG9HgAjA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=R/+6ER3HWe3u+qMNBLqQqawizgc3fOKZC4nKIiYxif9Pw5vRkNtjXpCrEnGlazpU3 DO0VegvUMoX59lzDt67Mv4D/+XeH608avjHRGutww6S5Fi184WCbhcC336/GvqskJr vZ48ZSvjyYtjBxzYBwThHBFRAWdaWRaXuN1yIaDE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390923AbfGHPfR (ORCPT ); Mon, 8 Jul 2019 11:35:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:37686 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733247AbfGHPfM (ORCPT ); Mon, 8 Jul 2019 11:35:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A6DA020651; Mon, 8 Jul 2019 15:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562600111; bh=TSKGw1r5dLtQbJRCdmKWf5HSmP9FklzelECTG9HgAjA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u8crBwuXzcpyHUJz1KH5Ak7VxTZVd0OO1/4x2a1h0BROC2zsrxIrfXMqn1U4e2Vo2 lvuPu/5l+75k41URLzvcDJpumCGbi+yU8IL98iTUIjPoQzeCfEm28Xb6XoFhWnhh9I r6T8J0cOxzxQiAz3jMsJh3EmuAalBkHF5AZ9JtuU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Sricharan R , Vinod Koul Subject: [PATCH 5.1 92/96] dmaengine: qcom: bam_dma: Fix completed descriptors count Date: Mon, 8 Jul 2019 17:14:04 +0200 Message-Id: <20190708150531.411233629@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190708150526.234572443@linuxfoundation.org> References: <20190708150526.234572443@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sricharan R commit f6034225442c4a87906d36e975fd9e99a8f95487 upstream. One space is left unused in circular FIFO to differentiate 'full' and 'empty' cases. So take that in to account while counting for the descriptors completed. Fixes the issue reported here, https://lkml.org/lkml/2019/6/18/669 Cc: stable@vger.kernel.org Reported-by: Srinivas Kandagatla Signed-off-by: Sricharan R Tested-by: Srinivas Kandagatla Signed-off-by: Vinod Koul Signed-off-by: Greg Kroah-Hartman --- drivers/dma/qcom/bam_dma.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/dma/qcom/bam_dma.c +++ b/drivers/dma/qcom/bam_dma.c @@ -808,6 +808,9 @@ static u32 process_channel_irqs(struct b /* Number of bytes available to read */ avail = CIRC_CNT(offset, bchan->head, MAX_DESCRIPTORS + 1); + if (offset < bchan->head) + avail--; + list_for_each_entry_safe(async_desc, tmp, &bchan->desc_list, desc_node) { /* Not enough data to read */