From: Guenter Roeck <linux@roeck-us.net>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
Peter Zijlstra <peterz@infradead.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 5/7] watchdog: ie6xx_wdt: Use spinlock_t instead of struct spinlock
Date: Mon, 8 Jul 2019 10:55:33 -0700 [thread overview]
Message-ID: <20190708175533.GA14138@roeck-us.net> (raw)
In-Reply-To: <20190704153803.12739-6-bigeasy@linutronix.de>
On Thu, Jul 04, 2019 at 05:38:01PM +0200, Sebastian Andrzej Siewior wrote:
> For spinlocks the type spinlock_t should be used instead of "struct
> spinlock".
>
> Use spinlock_t for spinlock's definition.
>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/ie6xx_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/ie6xx_wdt.c b/drivers/watchdog/ie6xx_wdt.c
> index 508fbefce9f6a..82a8cf61efc2a 100644
> --- a/drivers/watchdog/ie6xx_wdt.c
> +++ b/drivers/watchdog/ie6xx_wdt.c
> @@ -66,7 +66,7 @@ MODULE_PARM_DESC(resetmode,
>
> static struct {
> unsigned short sch_wdtba;
> - struct spinlock unlock_sequence;
> + spinlock_t unlock_sequence;
> #ifdef CONFIG_DEBUG_FS
> struct dentry *debugfs;
> #endif
next prev parent reply other threads:[~2019-07-08 17:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 15:37 [PATCH 0/7] Use spinlock_t instead of struct spinlock Sebastian Andrzej Siewior
2019-07-04 15:37 ` [PATCH 1/7] crypto: ux500: " Sebastian Andrzej Siewior
2019-07-26 12:10 ` Thomas Gleixner
2019-07-26 12:32 ` Herbert Xu
2019-07-04 15:37 ` [PATCH 2/7] vmpressure: " Sebastian Andrzej Siewior
2019-07-26 12:09 ` Thomas Gleixner
2019-07-26 22:50 ` Andrew Morton
2019-07-27 6:13 ` Thomas Gleixner
2019-07-04 15:37 ` [PATCH 3/7] drm/vgem: " Sebastian Andrzej Siewior
2019-07-04 15:38 ` [PATCH 4/7] staging: most: " Sebastian Andrzej Siewior
2019-07-06 10:02 ` Greg Kroah-Hartman
2019-07-06 21:35 ` Sebastian Andrzej Siewior
2019-07-15 19:19 ` Greg Kroah-Hartman
2019-07-26 11:22 ` [PATCH v2] staging: most: Use DEFINE_SPINLOCK() " Thomas Gleixner
2019-07-04 15:38 ` [PATCH 5/7] watchdog: ie6xx_wdt: Use spinlock_t " Sebastian Andrzej Siewior
2019-07-08 17:55 ` Guenter Roeck [this message]
2019-07-04 15:38 ` [PATCH 6/7] nfp: " Sebastian Andrzej Siewior
2019-07-04 20:42 ` Jakub Kicinski
2019-07-05 23:18 ` David Miller
2019-07-04 15:38 ` [PATCH 7/7] gpiolib: " Sebastian Andrzej Siewior
2019-07-05 9:33 ` Bartosz Golaszewski
2019-07-06 18:15 ` Linus Walleij
2019-07-04 15:39 ` [PATCH 0/7] " David Laight
2019-07-04 15:45 ` 'Sebastian Andrzej Siewior'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708175533.GA14138@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox