public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-m68k <linux-m68k@lists.linux-m68k.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Greg Ungerer <gerg@linux-m68k.org>
Subject: Re: [PATCH] m68k: don't select ARCH_HAS_DMA_PREP_COHERENT for nommu or coldfire
Date: Mon, 8 Jul 2019 23:23:25 +0200	[thread overview]
Message-ID: <20190708212325.GA17641@lst.de> (raw)
In-Reply-To: <CAMuHMdVrAVYWvQCh7AF1O7SRbuZb9fQp9fi0yQyZMeaOpfHyEw@mail.gmail.com>

On Mon, Jul 08, 2019 at 10:39:48PM +0200, Geert Uytterhoeven wrote:
> Hi Christoph,
> 
> On Mon, Jul 8, 2019 at 7:51 PM Christoph Hellwig <hch@lst.de> wrote:
> >
> > m68k only provides the dma_prep_coherent symbol when an mmu is enabled
> 
> arch_dma_prep_coherent
> 
> > and not on the coldfire platform.  Fix the Kconfig symbol selection
> > up to match this.
> >
> > Fixes: 69878ef47562 ("m68k: Implement arch_dma_prep_coherent()")
> 
> Do you know the SHA1 for the other commit, that causes the issue when
> combined with the above?

I think the culprit is:

commit c30700db9eaabb35e0b123301df35a6846e6b6b4
Author: Christoph Hellwig <hch@lst.de>
Date:   Mon Jun 3 08:43:51 2019 +0200

    dma-direct: provide generic support for uncached kernel segments


Ad it turns out I can't just apply this fix to the dma-mapping tree
because it doesn't have the m68k changes.  So either you'll have to
queue it up, or I'll have to do secondary pull request to fix up
the first one.  Maybe it is eiter if you just send it to Linus
before I send the dma-mapping PR?

  reply	other threads:[~2019-07-08 21:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08 17:51 [PATCH] m68k: don't select ARCH_HAS_DMA_PREP_COHERENT for nommu or coldfire Christoph Hellwig
2019-07-08 20:39 ` Geert Uytterhoeven
2019-07-08 21:23   ` Christoph Hellwig [this message]
2019-07-09  7:08     ` Geert Uytterhoeven
2019-07-09 13:36       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190708212325.GA17641@lst.de \
    --to=hch@lst.de \
    --cc=geert@linux-m68k.org \
    --cc=gerg@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox