From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55787C606B0 for ; Tue, 9 Jul 2019 00:05:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2232F216C4 for ; Tue, 9 Jul 2019 00:05:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562630732; bh=msEY9XkQx1moKb3qWxwfvcgn9s8MWFWJXMoCwOStO4w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=10AXaisJx0tgNBoAQ/ccV+xMjnsAzNPEelLAOd5wzTxFStfYPhEBPgWUYaSHLypf8 ka6r6csVIKHDshzFzYQSW1Cc43A1szZwmle4S2CrlYXfZxFiurF9hGmgJjV80w82+x M45C2s/UYOSVCxGOeQrLGSkyxVw9Ak2EOtV+nsU8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726089AbfGIAFa (ORCPT ); Mon, 8 Jul 2019 20:05:30 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:45924 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725889AbfGIAFa (ORCPT ); Mon, 8 Jul 2019 20:05:30 -0400 Received: by mail-pg1-f193.google.com with SMTP id o13so8459706pgp.12; Mon, 08 Jul 2019 17:05:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CYSKPajnikQfrdnXRZykFulg5ENG+KCQGBUGtfPGZlg=; b=XySjreBKv+XusN+hkcVisz9az8El9Zu66L6f9mfkraPNdKikw7BMMDAioD5TVC0fJI KnQf7tbBAmZB41FIaQRSUfoYi2Ct9rsrAVYbjBAAUOqHE71qDDL439VN3DKcEf7Rbfur aiQxmsyfdAjSH4RH18iLdyRPAZaMCJSR2yWRupqx9QF8Yo6BSgw1AGGPsNnYjkm8EQTt E3Oi5GOoYux9mihB+u4sZgjOvGbBEA5tcDN3z3I0O6bLXY/ujQCn/ierw+1OK2/Gk5Kp 529sJG+QHblIgqJP9dG72BMd2E0/PXTMKC5tOFlg3P0CVGA5h/9ha9bbknBhkewMgzRg 0HKg== X-Gm-Message-State: APjAAAVbot9LRdohtFUoZMS+qBXXkIDuM8xZAEF+AGEmmDXJaRoN6aTU eNDYmQseW7nhapeHQTcz3wM= X-Google-Smtp-Source: APXvYqw4OK/VNHzcsYf5IVMszz6XiUhKsoIQPlbh1mptNrGz8PLaicjkWYPvmUMoTQX4f7gMRu5fDA== X-Received: by 2002:a17:90a:ab01:: with SMTP id m1mr27995286pjq.69.1562630729425; Mon, 08 Jul 2019 17:05:29 -0700 (PDT) Received: from localhost ([2601:647:5b80:29f7:aba9:7dd5:dfa6:e012]) by smtp.gmail.com with ESMTPSA id i6sm15938258pgi.40.2019.07.08.17.05.28 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 08 Jul 2019 17:05:28 -0700 (PDT) Date: Mon, 8 Jul 2019 17:05:27 -0700 From: Moritz Fischer To: YueHaibing Cc: mdf@kernel.org, stillcompiling@gmail.com, atull@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org Subject: Re: [PATCH] fpga-manager: altera-ps-spi: Fix build error Message-ID: <20190709000527.GA1587@archbook> References: <20190708071356.50928-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190708071356.50928-1-yuehaibing@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 08, 2019 at 03:13:56PM +0800, YueHaibing wrote: > If BITREVERSE is m and FPGA_MGR_ALTERA_PS_SPI is y, > build fails: > > drivers/fpga/altera-ps-spi.o: In function `altera_ps_write': > altera-ps-spi.c:(.text+0x4ec): undefined reference to `byte_rev_table' > > Select BITREVERSE to fix this. > > Reported-by: Hulk Robot > Fixes: fcfe18f885f6 ("fpga-manager: altera-ps-spi: use bitrev8x4") > Signed-off-by: YueHaibing > --- > drivers/fpga/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index 474f304..cdd4f73 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -40,6 +40,7 @@ config ALTERA_PR_IP_CORE_PLAT > config FPGA_MGR_ALTERA_PS_SPI > tristate "Altera FPGA Passive Serial over SPI" > depends on SPI > + select BITREVERSE > help > FPGA manager driver support for Altera Arria/Cyclone/Stratix > using the passive serial interface over SPI. > -- > 2.7.4 > > Acked-by: Moritz Fischer