From: Guenter Roeck <linux@roeck-us.net>
To: Fabian Schindlatz <fabian.schindlatz@fau.de>
Cc: linux-hwmon@vger.kernel.org, Len Brown <len.brown@intel.com>,
tglx@linutronix.de, Ingo Molnar <mingo@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] hwmon: Correct struct allocation style
Date: Mon, 8 Jul 2019 18:22:33 -0700 [thread overview]
Message-ID: <20190709012233.GA311@roeck-us.net> (raw)
Hi,
On Thu, Jun 27, 2019 at 05:27:38PM +0200, Fabian Schindlatz wrote:
> Use sizeof(*var) instead of sizeof(struct var_type) as argument to
> kalloc() and friends to comply with the kernel coding style.
>
> Co-developed-by: Thomas Röthenbacher <thomas.roethenbacher@fau.de>
> Signed-off-by: Thomas Röthenbacher <thomas.roethenbacher@fau.de>
> Signed-off-by: Fabian Schindlatz <fabian.schindlatz@fau.de>
> [groeck: Resolved comment conflict against -next]
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This patch causes conflicts in -next due to commit 835896a59b95
("hwmon/coretemp: Cosmetic: Rename internal variables to zones
from packages"), which is not being submitted through the hwmon
subsystem. Unfortunately, the conflicts are more substantial than
I thought and not trivial. Since I have no control over the
conflicting patch, I decided to drop this patch from the hwmon
subsystem commit queue.
Please feel free to resubmit after the commit window closes.
I would suggest to drop the coretemp driver from the patch since
I don't know if further changes outside my control will be made
to that driver.
Sorry for the trouble.
Guenter
next reply other threads:[~2019-07-09 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 1:22 Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-06-27 11:56 [PATCH] hwmon: Correct struct allocation style Fabian Schindlatz
2019-06-27 12:06 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709012233.GA311@roeck-us.net \
--to=linux@roeck-us.net \
--cc=fabian.schindlatz@fau.de \
--cc=len.brown@intel.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox