From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 347F2C73C53 for ; Tue, 9 Jul 2019 18:32:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1490321537 for ; Tue, 9 Jul 2019 18:32:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562697152; bh=dxZWVgs9n6oX4BuH6iEjBVW2+cAQ9oiYK+/bO8q97v8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hBXNSGaV79VtbCIj2Si+r1rNJciU/7Vkxh/BEcRmeXMN0ZQGiLJStR895RN/XnYx2 O3mt/cdn/rpBoAwSmAic/F0fX8h9Zx4prfjazto/Vl/HA/H+yrytdj6OaXxqTLyjpF JVyn+3Y1VLYZ3zUkSXKW/iKdT9gDXNjtw/9xj4zc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729142AbfGIScb (ORCPT ); Tue, 9 Jul 2019 14:32:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:53906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729094AbfGISca (ORCPT ); Tue, 9 Jul 2019 14:32:30 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.35.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F3570217D4; Tue, 9 Jul 2019 18:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562697148; bh=dxZWVgs9n6oX4BuH6iEjBVW2+cAQ9oiYK+/bO8q97v8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vKjD9ITQxsBeM+3cvY84A7VodueZfXF8NXkpCn7+uShqgRkg3itIetuAG8u4P3fTd KdR2hTV8cEIheRngoOSLlPZyLDpTUz59ztCiHFk6IayXjo9hJXPCS9JlxDuVk6VL9q +gPdFQxV0flkFZu7Pu046NV6+MaYpxH1l5uGD4OI= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , Leo Yan Subject: [PATCH 09/25] perf evsel: perf_evsel__name(NULL) is valid, no need to check evsel Date: Tue, 9 Jul 2019 15:31:10 -0300 Message-Id: <20190709183126.30257-10-acme@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190709183126.30257-1-acme@kernel.org> References: <20190709183126.30257-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo It'll return "unknown", no need to open code it. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Leo Yan Cc: Namhyung Kim Link: https://lkml.kernel.org/n/tip-4okvjmm18arjrcyfhuahgfxm@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-report.c | 2 +- tools/perf/util/session.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index aef59f318a67..93d4b12e248e 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -298,7 +298,7 @@ static int process_read_event(struct perf_tool *tool, struct report *rep = container_of(tool, struct report, tool); if (rep->show_threads) { - const char *name = evsel ? perf_evsel__name(evsel) : "unknown"; + const char *name = perf_evsel__name(evsel); int err = perf_read_values_add_value(&rep->show_threads_values, event->read.pid, event->read.tid, evsel->idx, diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 2e61dd6a3574..e3463df18493 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -1246,7 +1246,7 @@ static void dump_read(struct perf_evsel *evsel, union perf_event *event) return; printf(": %d %d %s %" PRIu64 "\n", event->read.pid, event->read.tid, - evsel ? perf_evsel__name(evsel) : "FAIL", + perf_evsel__name(evsel), event->read.value); if (!evsel) -- 2.21.0