Re: hmm_range_fault related fixes and legacy API removal v2

Jason Gunthorpe
2019-07-23T15:20:26Z

On Mon, Jul 22, 2019 at 06:11:04PM -0700, Ralph Campbell wrote:
>
> On 7/22/19 2:44 AM, Christoph Hellwig wrote:
> > Hi Jérôme, Ben and Jason,
> >
> > below is a series against the hmm tree which fixes up the mmap_sem
> > locking in nouveau and while at it also removes leftover legacy HMM APIs
> > only used by nouveau.
> >
> > The first 4 patches are a bug fix for nouveau, which I suspect should
> > go into this merge window even if the code is marked as staging, just
> > to avoid people copying the breakage.
> >
> > Changes since v1:
> > - don't return the valid state from hmm_range_unregister
> > - additional nouveau cleanups
> >
>
> I ran some OpenCL tests from Jerome with nouveau and this series,
> 5.3.0-rc1, and my two HMM fixes:
> ("mm/hmm: fix ZONE_DEVICE anon page mapping reuse")
> ("mm/hmm: Fix bad subpage pointer in try_to_unmap_one")
>
> You can add for the series:
> Tested-by: Ralph Campbell <rcampbell@nvidia.com>

Thanks, would you also rebase and resend the patch deleting
struct hmm_update ?

Jason