From: Tejun Heo <tj@kernel.org>
To: Corey Minyard <minyard@acm.org>
Cc: openipmi-developer@lists.sourceforge.net, kernel-team@fb.com,
linux-kernel@vger.kernel.org
Subject: Re: [Openipmi-developer] [PATCH] ipmi_si_intf: use usleep_range() instead of busy looping
Date: Wed, 10 Jul 2019 07:12:00 -0700 [thread overview]
Message-ID: <20190710141200.GN657710@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <20190709230703.GF19430@minyard.net>
Hello, Corey.
On Tue, Jul 09, 2019 at 06:07:03PM -0500, Corey Minyard wrote:
> I believe the change was 33979734cd35ae "IPMI: use schedule in kthread"
> The original change that added the kthread was a9a2c44ff0a1350
> "ipmi: add timer thread".
>
> I mis-remembered this, we switched from doing a udelay() to
> schedule(), but that udelay was 1us, so that's probably not helpful
> information.
I see, so it went from non-yielding busy looping to an yiedling one.
And, yeah, udelay(1) isn't much of a data point.
Thanks.
--
tejun
prev parent reply other threads:[~2019-07-10 14:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 21:06 [PATCH] ipmi_si_intf: use usleep_range() instead of busy looping Tejun Heo
2019-07-09 21:46 ` Corey Minyard
2019-07-09 22:09 ` Tejun Heo
2019-07-09 23:01 ` Corey Minyard
2019-07-10 14:22 ` Tejun Heo
2019-07-10 20:11 ` Corey Minyard
2019-08-01 17:40 ` Corey Minyard
2019-08-05 18:18 ` Tejun Heo
2019-08-05 21:18 ` Corey Minyard
2019-08-07 18:27 ` Tejun Heo
2019-07-09 22:11 ` Tejun Heo
2019-07-09 23:07 ` [Openipmi-developer] " Corey Minyard
2019-07-10 14:12 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190710141200.GN657710@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox