public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@mellanox.com>
To: "Marciniszyn, Mike" <mike.marciniszyn@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	"Dalessandro, Dennis" <dennis.dalessandro@intel.com>,
	Doug Ledford <dledford@redhat.com>,
	"Arumugam, Kamenee" <kamenee.arumugam@intel.com>,
	Shamir Rabinovitch <shamir.rabinovitch@oracle.com>,
	Gal Pressman <galpress@amazon.com>,
	Leon Romanovsky <leon@kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"clang-built-linux@googlegroups.com" 
	<clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable
Date: Wed, 10 Jul 2019 16:58:16 +0000	[thread overview]
Message-ID: <20190710165812.GK2887@mellanox.com> (raw)
In-Reply-To: <32E1700B9017364D9B60AED9960492BC70E0B90C@fmsmsx120.amr.corp.intel.com>

On Wed, Jul 10, 2019 at 04:54:33PM +0000, Marciniszyn, Mike wrote:
> > Subject: [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable
> > 
> > I can't think of any reason for the inner variable declaration, so
> > remove it to avoid the issue.
> > 
> 
> I agree!
> 
> > Fixes: 239b0e52d8aa ("IB/hfi1: Move rvt_cq_wc struct into uapi directory")
> 
> Thanks for catching this!
> 
> Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>

Thanks, I'm going to take Nathan's identical patch though, it arrived
first

Jason

      reply	other threads:[~2019-07-10 16:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10 13:07 [PATCH] [net-next] IB/hfi1: removed shadowed 'err' variable Arnd Bergmann
2019-07-10 16:54 ` Marciniszyn, Mike
2019-07-10 16:58   ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190710165812.GK2887@mellanox.com \
    --to=jgg@mellanox.com \
    --cc=arnd@arndb.de \
    --cc=clang-built-linux@googlegroups.com \
    --cc=dennis.dalessandro@intel.com \
    --cc=dledford@redhat.com \
    --cc=galpress@amazon.com \
    --cc=kamenee.arumugam@intel.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mike.marciniszyn@intel.com \
    --cc=shamir.rabinovitch@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox