From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54DB1C74A35 for ; Wed, 10 Jul 2019 19:16:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 38F7A20651 for ; Wed, 10 Jul 2019 19:16:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728260AbfGJTQk (ORCPT ); Wed, 10 Jul 2019 15:16:40 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:47385 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727612AbfGJTQk (ORCPT ); Wed, 10 Jul 2019 15:16:40 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id EF28B805E5; Wed, 10 Jul 2019 21:16:26 +0200 (CEST) Date: Wed, 10 Jul 2019 21:16:37 +0200 From: Pavel Machek To: Jean-Jacques Hiblot Cc: jacek.anaszewski@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, lee.jones@linaro.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, dmurphy@ti.com, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com Subject: Re: [PATCH v3 4/4] backlight: add led-backlight driver Message-ID: <20190710191637.GD22995@amd> References: <20190710123932.28244-1-jjhiblot@ti.com> <20190710123932.28244-5-jjhiblot@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gE7i1rD7pdK0Ng3j" Content-Disposition: inline In-Reply-To: <20190710123932.28244-5-jjhiblot@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gE7i1rD7pdK0Ng3j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2019-07-10 14:39:32, Jean-Jacques Hiblot wrote: > From: Tomi Valkeinen >=20 > This patch adds a led-backlight driver (led_bl), which is similar to > pwm_bl except the driver uses a LED class driver to adjust the > brightness in the HW. Multiple LEDs can be used for a single backlight. >=20 > Signed-off-by: Tomi Valkeinen > Signed-off-by: Jean-Jacques Hiblot > + > + /* > + *try to map actual LED brightness to backlight brightness > + * level > + */ "* Try" > + db =3D priv->default_brightness; > + for (i =3D 0 ; i < num_levels; i++) { > + if ((i && db > levels[i-1]) && db <=3D levels[i]) > + break; > + } > + priv->default_brightness =3D i; > + priv->max_brightness =3D num_levels - 1; > + priv->levels =3D levels; > + } else if (num_levels >=3D 0) > + dev_warn(dev, "not enought levels defined\n"); "Not enough" > + ret =3D of_property_read_u32(node, "default-brightness-level", &value); > + if (!ret && value <=3D priv->max_brightness) > + priv->default_brightness =3D value; > + else if (!ret && value > priv->max_brightness) > + dev_warn(dev, "invalid default brightness. ignoring it\n"); "Invalid... Ignoring it." Acked-by: Pavel Machek Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --gE7i1rD7pdK0Ng3j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl0mOZUACgkQMOfwapXb+vKGjACbBk0etpxF6Viyuje0o1lj4McY wJgAoKbPa8b/CQqQPf5ELQ7VvqyxdarH =TOSr -----END PGP SIGNATURE----- --gE7i1rD7pdK0Ng3j--