From: Nathan Chancellor <natechancellor@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Wen Yang <wen.yang99@zte.com.cn>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH v2] ASoC: audio-graph-card: Constify reg in graph_get_dai_id
Date: Thu, 11 Jul 2019 20:52:44 -0700 [thread overview]
Message-ID: <20190712035244.GA67442@archlinux-epyc> (raw)
In-Reply-To: <87muhk53j1.wl-kuninori.morimoto.gx@renesas.com>
On Fri, Jul 12, 2019 at 12:37:51PM +0900, Kuninori Morimoto wrote:
>
> Hi Nathan
>
> > clang errors:
> >
> > sound/soc/generic/audio-graph-card.c:87:7: error: assigning to 'u32 *'
> > (aka 'unsigned int *') from 'const void *' discards qualifiers
> > [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> > reg = of_get_property(node, "reg", NULL);
> > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 1 error generated.
> >
> > Move the declaration up a bit to keep the reverse christmas tree look.
> >
> > Fixes: c152f8491a8d ("ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()")
> > Link: https://github.com/ClangBuiltLinux/linux/issues/600
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> > ---
>
> Maybe
>
> ec3042ad39d4e2ddbc3a3344f90bb10d8feb53bc
> ("ASoC: audio-graph-card: add missing const at graph_get_dai_id()")
>
> Thank you for your help !!
> Best regards
> ---
> Kuninori Morimoto
Ugh, I even checked Mark's tree before sending this, just completely
glossed over that patch. Sorry for the noise :(
Cheers,
Nathan
prev parent reply other threads:[~2019-07-12 3:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 1:43 [PATCH] ASoC: audio-graph-card: Constify reg in graph_get_dai_id Nathan Chancellor
2019-07-12 1:45 ` [PATCH v2] " Nathan Chancellor
2019-07-12 3:37 ` Kuninori Morimoto
2019-07-12 3:52 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712035244.GA67442@archlinux-epyc \
--to=natechancellor@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox