public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Bernard Metzler <BMT@zurich.ibm.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
	Doug Ledford <dledford@redhat.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] rdma/siw: avoid smp_store_mb() on a u64
Date: Fri, 12 Jul 2019 15:19:30 +0200	[thread overview]
Message-ID: <20190712131930.GT3419@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <OF36428621.B839DE8B-ON00258435.00461748-00258435.0047E413@notes.na.collabserv.com>

On Fri, Jul 12, 2019 at 01:05:14PM +0000, Bernard Metzler wrote:
> @@ -1131,6 +1131,10 @@ int siw_poll_cq(struct ib_cq *base_cq, int num_cqe, struct ib_wc *wc)
>   *   number of not reaped CQE's regardless of its notification
>   *   type and current or new CQ notification settings.
>   *
> + * This function gets called only by kernel consumers.
> + * Notification state must immediately become visible to all
> + * associated kernel producers (QP's).

No amount of memory barriers can achieve that goal.

  reply	other threads:[~2019-07-12 13:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12  8:51 [PATCH] rdma/siw: avoid smp_store_mb() on a u64 Arnd Bergmann
2019-07-12 11:33 ` Bernard Metzler
2019-07-12 11:47   ` Peter Zijlstra
2019-07-12 12:03   ` Jason Gunthorpe
2019-07-12 12:27     ` Bernard Metzler
2019-07-12 13:05     ` Bernard Metzler
2019-07-12 13:19       ` Peter Zijlstra [this message]
2019-07-12 13:35         ` Bernard Metzler
2019-07-12 13:22       ` Arnd Bergmann
2019-07-12 15:14         ` Jason Gunthorpe
2019-07-12 20:24           ` Arnd Bergmann
2019-07-12 13:53       ` Jason Gunthorpe
2019-07-12 14:35         ` Bernard Metzler
2019-07-12 14:42           ` Jason Gunthorpe
2019-07-12 15:24             ` Bernard Metzler
2019-07-12 15:32               ` Jason Gunthorpe
2019-07-12 17:40                 ` Bernard Metzler
2019-07-12 17:45                   ` Jason Gunthorpe
2019-07-12 18:06                     ` Bernard Metzler
2019-07-12 16:12               ` Peter Zijlstra
2019-07-25 17:23 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190712131930.GT3419@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=BMT@zurich.ibm.com \
    --cc=arnd@arndb.de \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox