From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77489C742D1 for ; Fri, 12 Jul 2019 17:20:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 473932080A for ; Fri, 12 Jul 2019 17:20:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="hs/4tn0a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727255AbfGLRUw (ORCPT ); Fri, 12 Jul 2019 13:20:52 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:36945 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726628AbfGLRUv (ORCPT ); Fri, 12 Jul 2019 13:20:51 -0400 Received: by mail-pg1-f194.google.com with SMTP id g15so4823823pgi.4 for ; Fri, 12 Jul 2019 10:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fDCFU21FX7iM5hltBSKXQsZERfbhCks0C3SkuZDn2cE=; b=hs/4tn0aPaP+ck9KP/2MF+L9GRraPJWDLdGluAhn9MyOgAVPRH/7GePpo5Hy1x1XOc cdVpTXeDtPXaxlVaHRFSawAMbTbMX5BJPysseSxoJPleGw+/jFCT9gWK6HCjj4wOeGw2 lSjyPogelCri9o41NPGUecEdHWIKz78j5bYNQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fDCFU21FX7iM5hltBSKXQsZERfbhCks0C3SkuZDn2cE=; b=HdAhxnh9kM/riYL2ky/l2HRKghFPtABl6kBt8roKXpLB+yLmCSmpRTp5iw7PElaa2O /RXDij4APcpj7XNWIYxPAK+WRd9gNUrOBryXewYe4Jp7VZIZRshyHhcR50yMeL1LUGX5 rCNulmFJ4NxBoIvGVAwk5AVpkGsWEbX0jJwfEORJgh/Ri/0eoFqfal+Q1c154baKFbQK e5j2SMStxmy4LX6ZFR7dacA7qweYijaJr4Uexcb8gsmAynWPih053GuG0HBF6GZoyh8I gjzySCUgvZEgQEmFzgwbFVWIhloeOdyRMVkBTKfz5OpPM2qetkAEakQvxhEc9bWTCulg Z/Bw== X-Gm-Message-State: APjAAAXAkzOqvGHWTXopP9/1SRr/6CIp05QhGFhGkBfD/Nh5bEw4UvS/ HLa2+V/NrlMO3k1wcEpn+tSgJgdxp8M= X-Google-Smtp-Source: APXvYqzRDHVjZQZvO/SrwW+PdfFvVs8Qylpul2+xzXOpUfwsEv0jARgp9zmgNN1kX2jftitaJA433Q== X-Received: by 2002:a63:6b46:: with SMTP id g67mr12122087pgc.45.1562952050999; Fri, 12 Jul 2019 10:20:50 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id g9sm7275782pgs.78.2019.07.12.10.20.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jul 2019 10:20:49 -0700 (PDT) Date: Fri, 12 Jul 2019 10:20:47 -0700 From: Matthias Kaehlcke To: Rob Herring Cc: Florian Fainelli , "David S . Miller" , Mark Rutland , Andrew Lunn , Heiner Kallweit , netdev , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Douglas Anderson Subject: Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode Message-ID: <20190712172047.GQ250418@google.com> References: <20190703193724.246854-1-mka@chromium.org> <20190703193724.246854-6-mka@chromium.org> <20190703232331.GL250418@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 10, 2019 at 09:55:12AM -0600, Rob Herring wrote: > On Wed, Jul 3, 2019 at 5:23 PM Matthias Kaehlcke wrote: > > > > Hi Florian, > > > > On Wed, Jul 03, 2019 at 02:37:47PM -0700, Florian Fainelli wrote: > > > On 7/3/19 12:37 PM, Matthias Kaehlcke wrote: > > > > The LED behavior of some Realtek PHYs is configurable. Add the > > > > property 'realtek,led-modes' to specify the configuration of the > > > > LEDs. > > > > > > > > Signed-off-by: Matthias Kaehlcke > > > > --- > > > > Changes in v2: > > > > - patch added to the series > > > > --- > > > > .../devicetree/bindings/net/realtek.txt | 9 +++++++++ > > > > include/dt-bindings/net/realtek.h | 17 +++++++++++++++++ > > > > 2 files changed, 26 insertions(+) > > > > create mode 100644 include/dt-bindings/net/realtek.h > > > > > > > > diff --git a/Documentation/devicetree/bindings/net/realtek.txt b/Documentation/devicetree/bindings/net/realtek.txt > > > > index 71d386c78269..40b0d6f9ee21 100644 > > > > --- a/Documentation/devicetree/bindings/net/realtek.txt > > > > +++ b/Documentation/devicetree/bindings/net/realtek.txt > > > > @@ -9,6 +9,12 @@ Optional properties: > > > > > > > > SSC is only available on some Realtek PHYs (e.g. RTL8211E). > > > > > > > > +- realtek,led-modes: LED mode configuration. > > > > + > > > > + A 0..3 element vector, with each element configuring the operating > > > > + mode of an LED. Omitted LEDs are turned off. Allowed values are > > > > + defined in "include/dt-bindings/net/realtek.h". > > > > > > This should probably be made more general and we should define LED modes > > > that makes sense regardless of the PHY device, introduce a set of > > > generic functions for validating and then add new function pointer for > > > setting the LED configuration to the PHY driver. This would allow to be > > > more future proof where each PHY driver could expose standard LEDs class > > > devices to user-space, and it would also allow facilities like: ethtool > > > -p to plug into that. > > > > > > Right now, each driver invents its own way of configuring LEDs, that > > > does not scale, and there is not really a good reason for that other > > > than reviewing drivers in isolation and therefore making it harder to > > > extract the commonality. Yes, I realize that since you are the latest > > > person submitting something in that area, you are being selected :) > > I agree. > > > I see the merit of your proposal to come up with a generic mechanism > > to configure Ethernet LEDs, however I can't justify spending much of > > my work time on this. If it is deemed useful I'm happy to send another > > version of the current patchset that addresses the reviewer's comments, > > but if the implementation of a generic LED configuration interface is > > a requirement I will have to abandon at least the LED configuration > > part of this series. > > Can you at least define a common binding for this. Maybe that's just > removing 'realtek'. While the kernel side can evolve to a common > infrastructure, the DT bindings can't. Defining a common binding sounds good to me, I will follow up on Florian's reply to this.