Re: [PATCH v4 2/3] i3c: move i3c_device_match_id to device.c and export it

Boris Brezillon
2019-07-12T16:34:43Z

On Fri, 12 Jul 2019 16:21:49 +0000
Vitor Soares <Vitor.Soares@synopsys.com> wrote:

> >
> > You're missing a kerneldoc here.
>
> I will do that. Can you clarify why we need that?
>

So the function is properly documented here [1].

> >
> > > +const struct i3c_device_id *
> > > +i3c_device_match_id(struct i3c_device *i3cdev,
> > > + const struct i3c_device_id *id_table)
> > > +{
> > > + struct i3c_device_info devinfo;
> > > + const struct i3c_device_id *id;
> > > +
> > > + i3c_device_get_info(i3cdev, &devinfo);
> > > +
> > > + /*
> > > + * The lower 32bits of the provisional ID is just filled with a random
> > > + * value, try to match using DCR info.
> > > + */
> > > + if (!I3C_PID_RND_LOWER_32BITS(devinfo.pid)) {
> > > + u16 manuf = I3C_PID_MANUF_ID(devinfo.pid);
> > > + u16 part = I3C_PID_PART_ID(devinfo.pid);
> > > + u16 ext_info = I3C_PID_EXTRA_INFO(devinfo.pid);
> > > +
> > > + /* First try to match by manufacturer/part ID. */
> > > + for (id = id_table; id->match_flags != 0; id++) {
> > > + if ((id->match_flags & I3C_MATCH_MANUF_AND_PART) !=
> > > + I3C_MATCH_MANUF_AND_PART)
> > > + continue;
> > > +
> > > + if (manuf != id->manuf_id || part != id->part_id)
> > > + continue;
> > > +
> > > + if ((id->match_flags & I3C_MATCH_EXTRA_INFO) &&
> > > + ext_info != id->extra_info)
> > > + continue;
> > > +
> > > + return id;
> > > + }
> > > + }
> > > +
> > > + /* Fallback to DCR match. */
> > > + for (id = id_table; id->match_flags != 0; id++) {
> > > + if ((id->match_flags & I3C_MATCH_DCR) &&
> > > + id->dcr == devinfo.dcr)
> > > + return id;
> > > + }
> > > +
> > > + return NULL;
> > > +}
> > > +EXPORT_SYMBOL_GPL(i3c_device_match_id);
> > > +

[1]https://www.kernel.org/doc/html/latest/driver-api/i3c/device-driver-api.html