From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=/nvU=VK=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id CC4F6C742A7
	for <linux-kernel@archiver.kernel.org>; Sat, 13 Jul 2019 07:26:12 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 84F9D204FD
	for <linux-kernel@archiver.kernel.org>; Sat, 13 Jul 2019 07:26:12 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726551AbfGMH0F (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Sat, 13 Jul 2019 03:26:05 -0400
Received: from verein.lst.de ([213.95.11.211]:43704 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726274AbfGMH0E (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 13 Jul 2019 03:26:04 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 5FAB568B02; Sat, 13 Jul 2019 09:26:03 +0200 (CEST)
Date:   Sat, 13 Jul 2019 09:26:03 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Logan Gunthorpe <logang@deltatee.com>
Cc:     linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: Re: [PATCH] nvmet-file: fix nvmet_file_flush() always returning an
 error
Message-ID: <20190713072603.GA17589@lst.de>
References: <20190712224207.22061-1-logang@deltatee.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190712224207.22061-1-logang@deltatee.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 12, 2019 at 04:42:07PM -0600, Logan Gunthorpe wrote:
> errno_to_nvme_status() doesn't take into account the case
> when errno=0, all other use cases only call it if there is actually
> an error.

Might it make more sense to handle 0 in errno_to_nvme_status to avoid
future problems like this one as well?  That would also match the
similar blk_to_nvme_status function better.