From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C198C76191 for ; Mon, 15 Jul 2019 15:06:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C701F206B8 for ; Mon, 15 Jul 2019 15:06:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563203208; bh=7EtuJgPzcudiPk5xwcfFj98UTAkfr0vJDCgWmRFLuU8=; h=From:To:Cc:Subject:Date:List-ID:From; b=nsVo/vInkmLSiTt/MlxmcRcC+O9/Sr4cr1vpexmEpoTAmGSWM3YHQyo1bQ8VpLYN2 rJcMly09aUIEu2hA8rb7jwGHgKVjFE6lOD6gT7X3XRRHiqnywWVamoDcZ+L5kSJOJY aRiXjT7jo/axcetJmIw25tkqVl4Y2Yd7RPD3rZqQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388531AbfGOPGr (ORCPT ); Mon, 15 Jul 2019 11:06:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46294 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387723AbfGOOE3 (ORCPT ); Mon, 15 Jul 2019 10:04:29 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A6D3759440; Mon, 15 Jul 2019 14:04:29 +0000 (UTC) Received: from krava.redhat.com (unknown [10.40.205.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0B45B6085B; Mon, 15 Jul 2019 14:04:26 +0000 (UTC) From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: David Carrillo-Cisneros , Song Liu , Kan Liang , Arnaldo Carvalho de Melo , lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra Subject: [PATCH] perf tools: Fix proper buffer size for feature processing Date: Mon, 15 Jul 2019 16:04:26 +0200 Message-Id: <20190715140426.32509-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 15 Jul 2019 14:04:29 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After Song Liu's segfault fix for pipe mode, Arnaldo reported following error: # perf record -o - | perf script 0x514 [0x1ac]: failed to process type: 80 It's caused by wrong buffer size setup in feature processing, which makes cpu topology feature fail, because it's using buffer size to recognize its header version. Cc: David Carrillo-Cisneros Cc: Song Liu Cc: Kan Liang Reported-by: Arnaldo Carvalho de Melo Fixes: e9def1b2e74e ("perf tools: Add feature header record to pipe-mode") Link: http://lkml.kernel.org/n/tip-2lj87zz8tq9ye1ntax3ulw0n@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/header.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index c24db7f4909c..20111f8da5cb 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -3747,7 +3747,7 @@ int perf_event__process_feature(struct perf_session *session, return 0; ff.buf = (void *)fe->data; - ff.size = event->header.size - sizeof(event->header); + ff.size = event->header.size - sizeof(*fe); ff.ph = &session->header; if (feat_ops[feat].process(&ff, NULL)) -- 2.21.0