From: Christoph Hellwig <hch@lst.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@fb.com>, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Paul Pawlowski <paul@mrarm.io>
Subject: Re: [PATCH 1/3] nvme: Pass the queue to SQ_SIZE/CQ_SIZE macros
Date: Tue, 16 Jul 2019 07:59:14 +0200 [thread overview]
Message-ID: <20190716055914.GA29414@lst.de> (raw)
In-Reply-To: <20190716004649.17799-1-benh@kernel.crashing.org>
On Tue, Jul 16, 2019 at 10:46:47AM +1000, Benjamin Herrenschmidt wrote:
> This will make it easier to handle variable queue entry sizes
> later. No functional change.
Looks good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2019-07-16 5:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 0:46 [PATCH 1/3] nvme: Pass the queue to SQ_SIZE/CQ_SIZE macros Benjamin Herrenschmidt
2019-07-16 0:46 ` [PATCH 2/3] nvme: Retrieve the required IO queue entry size from the controller Benjamin Herrenschmidt
2019-07-16 6:04 ` Christoph Hellwig
2019-07-16 6:21 ` Benjamin Herrenschmidt
2019-07-16 9:33 ` Christoph Hellwig
2019-07-16 10:58 ` Benjamin Herrenschmidt
2019-07-16 12:05 ` Christoph Hellwig
2019-07-16 12:17 ` Benjamin Herrenschmidt
2019-07-16 12:25 ` Christoph Hellwig
2019-07-16 0:46 ` [PATCH 3/3] nvme: Add support for Apple 2018+ models Benjamin Herrenschmidt
2019-07-16 6:06 ` Christoph Hellwig
2019-07-16 6:22 ` Benjamin Herrenschmidt
2019-07-16 0:49 ` [PATCH 1/3] nvme: Pass the queue to SQ_SIZE/CQ_SIZE macros Benjamin Herrenschmidt
2019-07-16 5:59 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716055914.GA29414@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=benh@kernel.crashing.org \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=paul@mrarm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox