From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=jE6e=VN=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 36A66C76192
	for <linux-kernel@archiver.kernel.org>; Tue, 16 Jul 2019 13:59:27 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 11C002173C
	for <linux-kernel@archiver.kernel.org>; Tue, 16 Jul 2019 13:59:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1563285567;
	bh=axm9oREaOJv1cVVP68RVtcE55RfxdvIVdg8ysfbSH3Y=;
	h=Date:From:To:Cc:Subject:List-ID:From;
	b=qHzYyZNaZZ1JkTMv7yHqZrQLvMdzF60hJoknIBBuayIHY1bDJ0luqY97JDUW1sJRn
	 YKL1yacZqNGQ+T4l7GaDVSV8vw13l1C4WWqBTWVtcqZfCn/fXhdnoULhwvfjglE3cN
	 Fgt5wFrNMtQ1Z39aLMYBSur2yxPZ5mwhwMsQSCT8=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2387526AbfGPN70 (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 16 Jul 2019 09:59:26 -0400
Received: from mail.kernel.org ([198.145.29.99]:49744 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726997AbfGPN7Z (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 16 Jul 2019 09:59:25 -0400
Received: from localhost (173-25-83-245.client.mchsi.com [173.25.83.245])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 5341020880;
        Tue, 16 Jul 2019 13:59:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1563285564;
        bh=axm9oREaOJv1cVVP68RVtcE55RfxdvIVdg8ysfbSH3Y=;
        h=Date:From:To:Cc:Subject:From;
        b=k7xbINaffR/KPZSMMRTCcPaMdONAeBGql3Q1D9AmKlfzx2nzngqR5fRSZyQBTypu4
         QJTMMOrnAwL6xTb9RWTrZdJcY4q6qPjfxGe6tGrGmd2b4ecEIGzgLaUNqHrmTo5aD5
         Ab10fEFBa1/A5oF1pjGB3KBd9mqZhDuerxgfsNJg=
Date:   Tue, 16 Jul 2019 08:59:23 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Kishon Vijay Abraham I <kishon@ti.com>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        linux-omap@vger.kernel.org, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: PCI: dra7xx: PCI_EXP_LNKCTL2 usage
Message-ID: <20190716135923.GA4470@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

ab5fe4f4d31e ("PCI: dra7xx: Add support to force RC to work in GEN1 mode")
added this:

  +       dw_pcie_cfg_read(pp->dbi_base + exp_cap_off + PCI_EXP_LNKCTL2,
  +                        2, &reg);
  +       if ((reg & PCI_EXP_LNKCAP_SLS) != PCI_EXP_LNKCAP_SLS_2_5GB) {
  +               reg &= ~((u32)PCI_EXP_LNKCAP_SLS);
  +               reg |= PCI_EXP_LNKCAP_SLS_2_5GB;
  +               dw_pcie_cfg_write(pp->dbi_base + exp_cap_off +
  +                                 PCI_EXP_LNKCTL2, 2, reg);
  +       }

This probably works as intended, but it *looks* wrong because it uses
LNKCAP_* symbols on LNKCTL2 register values.  We do have
PCI_EXP_LNKCTL2_* symbols, so I think it would be better if we used
used those.

Bjorn