From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30A96C7618F for ; Thu, 18 Jul 2019 20:46:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EDBD0208C0 for ; Thu, 18 Jul 2019 20:46:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391310AbfGRUqs (ORCPT ); Thu, 18 Jul 2019 16:46:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45622 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727687AbfGRUqs (ORCPT ); Thu, 18 Jul 2019 16:46:48 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3F70630C135E; Thu, 18 Jul 2019 20:46:48 +0000 (UTC) Received: from redhat.com (ovpn-120-147.rdu2.redhat.com [10.10.120.147]) by smtp.corp.redhat.com (Postfix) with SMTP id 17F2560920; Thu, 18 Jul 2019 20:46:29 +0000 (UTC) Date: Thu, 18 Jul 2019 16:46:28 -0400 From: "Michael S. Tsirkin" To: Andrew Morton Cc: Wei Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, xdeguillard@vmware.com, namit@vmware.com, pagupta@redhat.com, riel@surriel.com, dave.hansen@intel.com, david@redhat.com, konrad.wilk@oracle.com, yang.zhang.wz@gmail.com, nitesh@redhat.com, lcapitulino@redhat.com, aarcange@redhat.com, pbonzini@redhat.com, alexander.h.duyck@linux.intel.com, dan.j.williams@intel.com Subject: Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal Message-ID: <20190718164550-mutt-send-email-mst@kernel.org> References: <1563442040-13510-1-git-send-email-wei.w.wang@intel.com> <20190718082535-mutt-send-email-mst@kernel.org> <20190718133626.e30bec8fc506689b3daf48ee@linux-foundation.org> <20190718164152-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718164152-mutt-send-email-mst@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 18 Jul 2019 20:46:48 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 18, 2019 at 04:42:50PM -0400, Michael S. Tsirkin wrote: > On Thu, Jul 18, 2019 at 01:36:26PM -0700, Andrew Morton wrote: > > On Thu, 18 Jul 2019 08:26:11 -0400 "Michael S. Tsirkin" wrote: > > > > > On Thu, Jul 18, 2019 at 05:27:20PM +0800, Wei Wang wrote: > > > > Fixes: 418a3ab1e778 (mm/balloon_compaction: List interfaces) > > > > > > > > A #GP is reported in the guest when requesting balloon inflation via > > > > virtio-balloon. The reason is that the virtio-balloon driver has > > > > removed the page from its internal page list (via balloon_page_pop), > > > > but balloon_page_enqueue_one also calls "list_del" to do the removal. > > > > This is necessary when it's used from balloon_page_enqueue_list, but > > > > not from balloon_page_enqueue_one. > > > > > > > > So remove the list_del balloon_page_enqueue_one, and update some > > > > comments as a reminder. > > > > > > > > Signed-off-by: Wei Wang > > > > > > > > > ok I posted v3 with typo fixes. 1/2 is this patch with comment changes. Pls take a look. > > > > I really have no idea what you're talking about here :(. Some other > > discussion and patch thread, I suppose. > > > > You're OK with this patch? > > Not exactly. I will send v5 soon, you will be CC'd. Just done. Do you see it? > > Should this patch have cc:stable? > > Yes. Sorry. Actually no - 418a3ab1e778 is new since 5.2.