From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9E83C76195 for ; Fri, 19 Jul 2019 04:09:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7764B2189E for ; Fri, 19 Jul 2019 04:09:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563509376; bh=aLsdwTpMpfOml35aRANSXramiq7HO3wnjV9fDK1SdcQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=S5MNF20CW5XcHkGdnWgbnBQ1MKwIvLxo8v06hG+fpAmeL+Flb2FMS0N5jqRgMxE3d aA93QSRODwDEWqPrmh37Mac5Hu1jeb6Ww3E00ijKl90z1k9hlunjB7SpYOT4GWr5br TPZALWFBxY0yBCempXYCRS1kax7gfZk41oXWsBB4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732459AbfGSEJf (ORCPT ); Fri, 19 Jul 2019 00:09:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:43854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730127AbfGSEJW (ORCPT ); Fri, 19 Jul 2019 00:09:22 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB3E82189D; Fri, 19 Jul 2019 04:09:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563509361; bh=aLsdwTpMpfOml35aRANSXramiq7HO3wnjV9fDK1SdcQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lrJgGeKv1P31QH4GGrj00aavVqYFi1vxrTMy+DFjrg8uJhXS2EYUyB5lv1V6Qj31y N5o/uoI4/CIW3HK9Rh2tubrfLiXnRk7wRfaejMNSl25KHb9fTpmIENCxUm8lfhl453 aC6/ouffZXsW+0324oncxYh/mgZklt9xI90Z2DxM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Axel Lin , Chen Feng , Lee Jones , Sasha Levin Subject: [PATCH AUTOSEL 4.19 054/101] mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk Date: Fri, 19 Jul 2019 00:06:45 -0400 Message-Id: <20190719040732.17285-54-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190719040732.17285-1-sashal@kernel.org> References: <20190719040732.17285-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Axel Lin [ Upstream commit 7efd105c27fd2323789b41b64763a0e33ed79c08 ] Since devm_regmap_init_mmio_clk can fail, add return value checking. Signed-off-by: Axel Lin Acked-by: Chen Feng Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/hi655x-pmic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c index 96c07fa1802a..6693f74aa6ab 100644 --- a/drivers/mfd/hi655x-pmic.c +++ b/drivers/mfd/hi655x-pmic.c @@ -112,6 +112,8 @@ static int hi655x_pmic_probe(struct platform_device *pdev) pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base, &hi655x_regmap_config); + if (IS_ERR(pmic->regmap)) + return PTR_ERR(pmic->regmap); regmap_read(pmic->regmap, HI655X_BUS_ADDR(HI655X_VER_REG), &pmic->ver); if ((pmic->ver < PMU_VER_START) || (pmic->ver > PMU_VER_END)) { -- 2.20.1