From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4733C76195 for ; Fri, 19 Jul 2019 04:13:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74F2321851 for ; Fri, 19 Jul 2019 04:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563509637; bh=iRuFMwXhuMLce6qT7V7J15ncz3hLfMvGmvNr2ykkQfs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=N5qIkeKGTY+dbvDRX7+E1FjI3Jc6Xmwdp1UClR5kZMbYylZlADc2UPaLusgXTQrhE oootuL5NX06y9gkiWfaStX+JB9Z/Hf/sC2YQdB2UmUZbabp3aVAujfy5QXylan0Cgx +pPpVG+wUZKt+pUStda6xpbDXesMd8+EeOVF+TfE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729710AbfGSEN4 (ORCPT ); Fri, 19 Jul 2019 00:13:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:49952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389449AbfGSENy (ORCPT ); Fri, 19 Jul 2019 00:13:54 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A59DE21872; Fri, 19 Jul 2019 04:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563509633; bh=iRuFMwXhuMLce6qT7V7J15ncz3hLfMvGmvNr2ykkQfs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=teah+4Ln583x6LQiQ34L50igJzVnNwWo4IovY/Wgk+tyCXegyNN39q/qhHt7KxO7i BdPnN+mlNcvDN06yCDaD/GuO+gvptBnC8FMljEk50UyUmaq895XfdJja0ITSI8HcsQ r5A5KMh/9KAINzVUrOZgpjE8pOuPr8t9JvrUJqx4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Christian Lamparter , Michael Ellerman , Sasha Levin , linuxppc-dev@lists.ozlabs.org Subject: [PATCH AUTOSEL 4.9 29/45] powerpc/4xx/uic: clear pending interrupt after irq type/pol change Date: Fri, 19 Jul 2019 00:12:48 -0400 Message-Id: <20190719041304.18849-29-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190719041304.18849-1-sashal@kernel.org> References: <20190719041304.18849-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christian Lamparter [ Upstream commit 3ab3a0689e74e6aa5b41360bc18861040ddef5b1 ] When testing out gpio-keys with a button, a spurious interrupt (and therefore a key press or release event) gets triggered as soon as the driver enables the irq line for the first time. This patch clears any potential bogus generated interrupt that was caused by the switching of the associated irq's type and polarity. Signed-off-by: Christian Lamparter Signed-off-by: Michael Ellerman Signed-off-by: Sasha Levin --- arch/powerpc/sysdev/uic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/sysdev/uic.c b/arch/powerpc/sysdev/uic.c index a00949f3e378..a8ebc96dfed2 100644 --- a/arch/powerpc/sysdev/uic.c +++ b/arch/powerpc/sysdev/uic.c @@ -158,6 +158,7 @@ static int uic_set_irq_type(struct irq_data *d, unsigned int flow_type) mtdcr(uic->dcrbase + UIC_PR, pr); mtdcr(uic->dcrbase + UIC_TR, tr); + mtdcr(uic->dcrbase + UIC_SR, ~mask); raw_spin_unlock_irqrestore(&uic->lock, flags); -- 2.20.1