From: Pavel Machek <pavel@ucw.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
john.hubbard@gmail.com, SCheung@nvidia.com,
akpm@linux-foundation.org, aneesh.kumar@linux.vnet.ibm.com,
benh@kernel.crashing.org, bsingharora@gmail.com,
dan.j.williams@intel.com, dnellans@nvidia.com,
ebaskakov@nvidia.com, hannes@cmpxchg.org, jglisse@redhat.com,
jhubbard@nvidia.com, kirill.shutemov@linux.intel.com,
linux-kernel@vger.kernel.org, liubo95@huawei.com,
mhairgrove@nvidia.com, mhocko@kernel.org,
paulmck@linux.vnet.ibm.com, ross.zwisler@linux.intel.com,
sgutti@nvidia.com, torvalds@linux-foundation.org,
vdavydov.dev@gmail.com
Subject: Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option
Date: Fri, 19 Jul 2019 14:04:33 +0200 [thread overview]
Message-ID: <20190719120432.GC11224@amd> (raw)
In-Reply-To: <20190719120043.GA15320@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
On Fri 2019-07-19 05:00:43, Christoph Hellwig wrote:
> On Fri, Jul 19, 2019 at 08:48:53AM -0300, Jason Gunthorpe wrote:
> > It is like MMU_NOTIFIERS, if something needs it, then it will select
> > it.
> >
> > Maybe it should just be a hidden kconfig anyhow as there is no reason
> > to turn it on without also turning on a using driver.
>
> We can't just select it due to the odd X86_64 || PPC64 dependency.
>
> Which also answers Pavels question: you never really need it, as we
> can only use it for optional functionality due to that.
Okay, just explain it in the help text :-)..
Alternatively... you can have WANT_HMM_MIRROR option drivers select,
and option HMM_MIRROR which is yes if WANT_HMM_MIRROR && (X86_64 ||
PPC64), no?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-07-19 12:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 7:41 HMM_MIRROR has less than useful help text Pavel Machek
2019-07-18 11:03 ` Balbir Singh
2019-07-18 14:25 ` Dan Williams
2019-07-18 16:36 ` Pavel Machek
2019-07-19 1:32 ` [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option john.hubbard
2019-07-19 4:34 ` Ira Weiny
2019-07-19 5:15 ` John Hubbard
2019-07-19 5:57 ` Christoph Hellwig
2019-07-19 10:52 ` Pavel Machek
2019-07-19 11:48 ` Jason Gunthorpe
2019-07-19 12:00 ` Christoph Hellwig
2019-07-19 12:04 ` Pavel Machek [this message]
2019-07-19 20:38 ` John Hubbard
2019-07-22 11:58 ` Jason Gunthorpe
2019-07-22 12:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719120432.GC11224@amd \
--to=pavel@ucw.cz \
--cc=SCheung@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dnellans@nvidia.com \
--cc=ebaskakov@nvidia.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=john.hubbard@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liubo95@huawei.com \
--cc=mhairgrove@nvidia.com \
--cc=mhocko@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=ross.zwisler@linux.intel.com \
--cc=sgutti@nvidia.com \
--cc=torvalds@linux-foundation.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).