From: Luis Henriques <lhenriques@suse.com>
To: Ilya Dryomov <idryomov@gmail.com>,
Jeff Layton <jlayton@kernel.org>, Sage Weil <sage@redhat.com>
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Luis Henriques <lhenriques@suse.com>
Subject: [PATCH 0/4] Sleeping functions in invalid context bug fixes
Date: Fri, 19 Jul 2019 15:32:18 +0100 [thread overview]
Message-ID: <20190719143222.16058-1-lhenriques@suse.com> (raw)
Hi,
I'm sending three "sleeping function called from invalid context" bug
fixes that I had on my TODO for a while. All of them are ceph_buffer_put
related, and all the fixes follow the same pattern: delay the operation
until the ci->i_ceph_lock is released.
The first patch simply allows ceph_buffer_put to receive a NULL buffer so
that the NULL check doesn't need to be performed in all the other patches.
IOW, it's not really required, just convenient.
(Note: maybe these patches should all be tagged for stable.)
Luis Henriques (4):
libceph: allow ceph_buffer_put() to receive a NULL ceph_buffer
ceph: fix buffer free while holding i_ceph_lock in __ceph_setxattr()
ceph: fix buffer free while holding i_ceph_lock in
__ceph_build_xattrs_blob()
ceph: fix buffer free while holding i_ceph_lock in fill_inode()
fs/ceph/caps.c | 5 ++++-
fs/ceph/inode.c | 7 ++++---
fs/ceph/snap.c | 4 +++-
fs/ceph/super.h | 2 +-
fs/ceph/xattr.c | 19 ++++++++++++++-----
include/linux/ceph/buffer.h | 3 ++-
6 files changed, 28 insertions(+), 12 deletions(-)
next reply other threads:[~2019-07-19 14:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 14:32 Luis Henriques [this message]
2019-07-19 14:32 ` [PATCH 1/4] libceph: allow ceph_buffer_put() to receive a NULL ceph_buffer Luis Henriques
2019-07-19 14:32 ` [PATCH 2/4] ceph: fix buffer free while holding i_ceph_lock in __ceph_setxattr() Luis Henriques
2019-07-19 23:07 ` Jeff Layton
2019-07-19 23:23 ` Al Viro
2019-07-19 23:30 ` Al Viro
2019-07-20 0:35 ` Jeff Layton
2019-07-19 14:32 ` [PATCH 3/4] ceph: fix buffer free while holding i_ceph_lock in __ceph_build_xattrs_blob() Luis Henriques
2019-07-19 14:32 ` [PATCH 4/4] ceph: fix buffer free while holding i_ceph_lock in fill_inode() Luis Henriques
2019-07-19 15:20 ` [PATCH 0/4] Sleeping functions in invalid context bug fixes Jeff Layton
2019-07-23 10:02 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719143222.16058-1-lhenriques@suse.com \
--to=lhenriques@suse.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox