From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90FC3C7618F for ; Fri, 19 Jul 2019 15:15:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DBDB2173B for ; Fri, 19 Jul 2019 15:15:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728404AbfGSPPZ (ORCPT ); Fri, 19 Jul 2019 11:15:25 -0400 Received: from mga04.intel.com ([192.55.52.120]:59214 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726711AbfGSPPY (ORCPT ); Fri, 19 Jul 2019 11:15:24 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2019 08:15:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,282,1559545200"; d="scan'208";a="168581270" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.145]) by fmsmga008.fm.intel.com with ESMTP; 19 Jul 2019 08:15:20 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hoUbP-0005PW-IC; Fri, 19 Jul 2019 18:15:19 +0300 Date: Fri, 19 Jul 2019 18:15:19 +0300 From: Andy Shevchenko To: Navid Emamdoost , Kangjie Lu , Aditya Pakki Cc: emamd001@umn.edu, smccaman@umn.edu, Greg Kroah-Hartman , Jiri Slaby , Vinod Koul , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] 8250_lpss: check null return when calling pci_ioremap_bar Message-ID: <20190719151519.GO9224@smile.fi.intel.com> References: <20190719025443.2368-1-navid.emamdoost@gmail.com> <20190719133735.GM9224@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190719133735.GM9224@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 19, 2019 at 04:37:35PM +0300, Andy Shevchenko wrote: > On Thu, Jul 18, 2019 at 09:54:42PM -0500, Navid Emamdoost wrote: > Thus, please, collaborate guys, and send one compiling solution based on [1]. > [1]: https://www.spinics.net/lists/linux-serial/msg33965.html For your convenience (what has to be applied to v4): diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c index 53ca9ba6ab4b..6214da67e9b3 100644 --- a/drivers/tty/serial/8250/8250_lpss.c +++ b/drivers/tty/serial/8250/8250_lpss.c @@ -195,11 +195,15 @@ static void qrk_serial_setup_dma(struct lpss8250 *lpss, struct uart_port *port) static void qrk_serial_exit_dma(struct lpss8250 *lpss) { + struct dw_dma_chip *chip = &lpss->dma_chip; struct dw_dma_slave *param = &lpss->dma_param; if (!param->dma_dev) return; - dw_dma_remove(&lpss->dma_chip); + + dw_dma_remove(chip); + + pci_iounmap(to_pci_dev(chip->dev), chip->regs); } #else /* CONFIG_SERIAL_8250_DMA */ static void qrk_serial_setup_dma(struct lpss8250 *lpss, struct uart_port *port) {} -- With Best Regards, Andy Shevchenko