From: Matthias Kaehlcke <mka@chromium.org>
To: Adam Jackson <ajax@redhat.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Douglas Anderson <dianders@chromium.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller
Date: Fri, 19 Jul 2019 09:45:45 -0700 [thread overview]
Message-ID: <20190719164545.GU250418@google.com> (raw)
In-Reply-To: <617ef7670a35f0be6beba79ecdaba8be26154868.camel@redhat.com>
On Fri, Jul 19, 2019 at 12:23:26PM -0400, Adam Jackson wrote:
> On Thu, 2019-07-18 at 14:41 -0700, Matthias Kaehlcke wrote:
>
> > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > index 045b1b13fd0e..e49402ebd56f 100644
> > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > @@ -35,6 +35,7 @@
> >
> > #include <media/cec-notifier.h>
> >
> > +#define DDC_I2C_ADDR 0x37
>
> This confused the heck out of me to read, DDC by definition happens
> over I2C and this one address is just for a specific subset of DDC.
> Perhaps this would be clearer if it was named DDC_CI_ADDR.
I was also a bit confused about the terminology, some places call 0x37
the DDC address and 0x50 the EDID address.
DDC_CI_ADDR sounds good to me, thanks for the suggestion!
I'll wait a day or two before respinning, for if there are more comments.
prev parent reply other threads:[~2019-07-19 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 21:41 [PATCH] drm/bridge: dw-hdmi: Refuse DDC/CI transfers on the internal I2C controller Matthias Kaehlcke
2019-07-19 16:23 ` Adam Jackson
2019-07-19 16:45 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719164545.GU250418@google.com \
--to=mka@chromium.org \
--cc=Jose.Abreu@synopsys.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=ajax@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox