From: Hennie Muller <hm@bitlabs.co.za>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Tim Collier <osdevtc@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/wlan-ng: Fixing "line over 80 characters" warnings.
Date: Sun, 21 Jul 2019 12:03:40 +0200 [thread overview]
Message-ID: <20190721100340.fa4hmnj5mszlcppz@manjaro-1> (raw)
In-Reply-To: <20190721092919.GA9188@kroah.com>
On Sun, Jul 21, 2019 at 11:29:19AM +0200, Greg Kroah-Hartman wrote:
> On Sun, Jul 21, 2019 at 11:13:26AM +0200, Hennie Muller wrote:
> > Reindent multiline function calls to be tab aligned, instead of open brace
> > aligned. This fixes multiple "WARNING: line over 80 characters" generated
> > by checkpatch.
> >
> > Signed-off-by: Hennie Muller <hm@bitlabs.co.za>
> > ---
> > drivers/staging/wlan-ng/cfg80211.c | 55 ++---
> > drivers/staging/wlan-ng/hfa384x_usb.c | 282 +++++++++++++-------------
> > drivers/staging/wlan-ng/p80211conv.c | 48 +++--
> > drivers/staging/wlan-ng/p80211req.c | 6 +-
> > drivers/staging/wlan-ng/prism2fw.c | 101 +++++----
> > drivers/staging/wlan-ng/prism2mgmt.c | 170 ++++++++--------
> > drivers/staging/wlan-ng/prism2mib.c | 14 +-
> > drivers/staging/wlan-ng/prism2sta.c | 282 +++++++++++++-------------
> > drivers/staging/wlan-ng/prism2usb.c | 13 +-
> > 9 files changed, 494 insertions(+), 477 deletions(-)
> >
> > diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> > index eee1998c4b18..c69fb83267ef 100644
> > --- a/drivers/staging/wlan-ng/cfg80211.c
> > +++ b/drivers/staging/wlan-ng/cfg80211.c
> > @@ -130,8 +130,8 @@ static int prism2_change_virtual_intf(struct wiphy *wiphy,
> >
> > /* Set Operation mode to the PORT TYPE RID */
> > result = prism2_domibset_uint32(wlandev,
> > - DIDMIB_P2_STATIC_CNFPORTTYPE,
> > - data);
> > + DIDMIB_P2_STATIC_CNFPORTTYPE,
> > + data);
>
> This then violates another checkpatch warning, so you can't win :(
>
> Just leave it as-is, it's fine, right? Coding styles are there to make
> things easy to read and understand, and the code is fine like this.
Ok, perfect. I understand thanks. I'll move on to my next "first"
contribution then. :-)
>
> So don't move arguments to the left of the '(' character on the line
> above please.
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2019-07-21 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 9:13 [PATCH] staging/wlan-ng: Fixing "line over 80 characters" warnings Hennie Muller
2019-07-21 9:29 ` Greg Kroah-Hartman
2019-07-21 10:03 ` Hennie Muller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190721100340.fa4hmnj5mszlcppz@manjaro-1 \
--to=hm@bitlabs.co.za \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osdevtc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox