The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Chen, Rong A" <rong.a.chen@intel.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Shravan Kumar Ramani <sramani@mellanox.com>, LKP <lkp@01.org>,
	David Woods <dwoods@mellanox.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [LKP] [gpio] f69e00bd21: unixbench.score -24.2% regression
Date: Mon, 22 Jul 2019 09:27:50 +0800	[thread overview]
Message-ID: <20190722012750.GB50506@shbuild999.sh.intel.com> (raw)
In-Reply-To: <CACRpkdYmtgO_E-KKE8zjA04POawJ=4RN3xFUPY__7GF+gSNbNQ@mail.gmail.com>

Hi Linus,

On Wed, Jul 17, 2019 at 05:42:15AM +0800, Linus Walleij wrote:
> On Wed, Jul 10, 2019 at 2:15 PM kernel test robot <rong.a.chen@intel.com> wrote:
> 
> > FYI, we noticed a -24.2% regression of unixbench.score due to commit:
> > commit: f69e00bd21aa6a1961c521b6eb199137fcb8a76a ("gpio: mmio: Support two direction registers")
> > https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git master
> 
> That's pretty bogus since the test doesn't even seem to be using GPIO.
> Further AFAIK Intel chips don't even use that driver.
> 
> Can you provide some rootcausing?

We did some further check, and found this is a false alarm. That some recent 
change to LKP itself has enabled the latencytop for newer kernel(post 5.1-rc1),
and latencytop is known to bring extra system load to scheduling related
benchmarks like unixbench, which caused this -24.7 difference of unixbench
score. Sorry for the noise.

Thanks,
Feng


> If you are using GPIOs from userspace in the test somehow I am
> sure both me and Bartosz would be interested to hear how.
> 
> Yours,
> Linus Walleij
> _______________________________________________
> LKP mailing list
> LKP@lists.01.org
> https://lists.01.org/mailman/listinfo/lkp

      reply	other threads:[~2019-07-22  1:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10 12:15 [gpio] f69e00bd21: unixbench.score -24.2% regression kernel test robot
2019-07-16 21:42 ` Linus Walleij
2019-07-22  1:27   ` Feng Tang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190722012750.GB50506@shbuild999.sh.intel.com \
    --to=feng.tang@intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=dwoods@mellanox.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=rong.a.chen@intel.com \
    --cc=sramani@mellanox.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox