From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32EACC76188 for ; Mon, 22 Jul 2019 15:32:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04E2C214C6 for ; Mon, 22 Jul 2019 15:32:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="LqJPpEmU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729199AbfGVPcH (ORCPT ); Mon, 22 Jul 2019 11:32:07 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:39639 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728794AbfGVPcH (ORCPT ); Mon, 22 Jul 2019 11:32:07 -0400 Received: by mail-vs1-f68.google.com with SMTP id u3so26362460vsh.6 for ; Mon, 22 Jul 2019 08:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=83LVMuHoHjqhSQNZ1FrJgpxiHmtCkL35yfYZrLhbZjo=; b=LqJPpEmUB0a9Ke4CAk6JPoucs8wmtb+02DEs9QL9U+BbOfYQbgVeFVIqqlr7oQQAq8 3S/c31fXk9q8SoWg6oP7zCkjauQxi8XdeFPuuQU1NEBI6kkLLcblRlt8GzFe/je8gjix vOHkm5H5D1AnV47vAB88S13Je7Hl7mpBe3uFaxmZnvAvkAkKIX9vchXENhZeppe+VvUl MuaQ06MGkLEsK+UrErQamKgEpMwyq8lwf16j83TMQILggK/TJgS+7d8jfQRFFXYWYeGB 2JhobIzAQZt5zssUMglTgRGluDpjdCgIkrPqKnHvg060jjILe0hrONl32QrLFG+ZcDZh wPfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=83LVMuHoHjqhSQNZ1FrJgpxiHmtCkL35yfYZrLhbZjo=; b=Ndw7Zg2XLRvSNEgfhsHf6GKp1UJlZPh0NIJuDRfhSvW6XetORJwJmXgtuoNY6G2BIr 2ZY2n8Q7shkYRAYPG3PMfgMinoRirqMOkm0ci2CTyuwLH7zaR7+yt4EIq1JQ50AACy4f f1ymznuFN0QEwfn1cZEt2P5vytiIyb59Q/Ykx2ZU4+X1B5C0cHAqrDa9wVEoj3BYBSsw XYJ2WbdJKRVF7Xo5/51IlRh2t4KA+e8aPS6ixU2RwZr7ZiVuNvJ+NjS87uFFaJ9rsnZV TGXzJOBJQ9PI9J8PDxUSZ8MDUyxzr1B7L30L72k71WMRRs968XNTidKzx8aBKDpNh9YS JKkQ== X-Gm-Message-State: APjAAAVRMpOQVHBlH7nOr+l14L3fiIOsW6a4RfbTgonV+4BCtoP+Mmnv VX8P9dcnT37F1SC/ljFesbcsSw== X-Google-Smtp-Source: APXvYqwfMx7NNtKhAko8Xc/SzCmuGCf752a2RG6dd2WSCibeWR5f56T3h9COdwohxrypQTGs8RQ6+Q== X-Received: by 2002:a05:6102:1041:: with SMTP id h1mr42912194vsq.153.1563809526346; Mon, 22 Jul 2019 08:32:06 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id l184sm18097130vsl.8.2019.07.22.08.32.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jul 2019 08:32:05 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hpaIH-0004t3-Av; Mon, 22 Jul 2019 12:32:05 -0300 Date: Mon, 22 Jul 2019 12:32:05 -0300 From: Jason Gunthorpe To: Maksym Planeta Cc: Moni Shoua , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/10] Replace tasklets with workqueues Message-ID: <20190722153205.GG7607@ziepe.ca> References: <20190722151426.5266-1-mplaneta@os.inf.tu-dresden.de> <20190722151426.5266-11-mplaneta@os.inf.tu-dresden.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190722151426.5266-11-mplaneta@os.inf.tu-dresden.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 22, 2019 at 05:14:26PM +0200, Maksym Planeta wrote: > Replace tasklets with workqueues in rxe driver. > > Ensure that task is called only through a workqueue. This allows to > simplify task logic. > > Add additional dependencies to make sure that cleanup tasks do not > happen after object's memory is already reclaimed. > > Improve overal stability of the driver by removing multiple race > conditions and use-after-free situations. This should be described more precisely Jason