From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91CE9C7618F for ; Mon, 22 Jul 2019 17:14:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66ED22199C for ; Mon, 22 Jul 2019 17:14:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Wg10sjwF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731212AbfGVROY (ORCPT ); Mon, 22 Jul 2019 13:14:24 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:33276 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730910AbfGVROX (ORCPT ); Mon, 22 Jul 2019 13:14:23 -0400 Received: by mail-pf1-f194.google.com with SMTP id g2so17690524pfq.0 for ; Mon, 22 Jul 2019 10:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=av4K/5qGstnWqT+KixOJAjwc0aMoucfv3grHM7d8Df0=; b=Wg10sjwFDrllJKJWxerqg4KKcL8ekXXK42Di7QNalFV497CwGVno10FhlasPHk49sl IV7vL8Dbzypt9dWVNA4vJa+/N4jlaRgHUidWrvK6DapIHk8SieQP1JC14XnkdLdUUCtF +/IU9fno39aKBOoLBl8OYqHjuBQCIbqFNp3RE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=av4K/5qGstnWqT+KixOJAjwc0aMoucfv3grHM7d8Df0=; b=q6GO/yH+4SzqEUotZnRpChn12K+yqgfgNr/gXBYnk+hRZQYpsrIwmaCpSJTZYRt+iY ZQaj9Q7IVzKLFEmsw1QF5jQUExZfqjbS1exKzjCaMJP9pfe6kKE7b31Q8+LvOaNuCfcb jABoFDhcFhJPfI8QXG6Yuh4t+0v5kysPJ5T1H4YSCnULSzPq4AJEQPGKwp9N5ZyhCNgk ITxRVgWjafMhXMgFxL9HPJNFcXZgOC+Flcig2sVYgiAbcnf/4SiIqTzkmok8BKq3nwn4 9PcAwRPFiaFdXWDjR4Ijwt4cEH7elkPMKGkvzuLiwKhF8+tX99nfRk0oM8pulgcujfqm B9Lw== X-Gm-Message-State: APjAAAVhdAPE756PR491+nOYM7ffvqUvAiKs2sc+V2tbgFMdx+yroKwh zRfqiN2YLFQy9P9eQKArOwmB3g== X-Google-Smtp-Source: APXvYqwJhYH8OvAHF279yVgzP5VkN43swUuVvnPethKepZeaQvFKh9nQKqMeYTjVFkGMTa5HY3te1g== X-Received: by 2002:a62:2ad3:: with SMTP id q202mr1310794pfq.161.1563815662866; Mon, 22 Jul 2019 10:14:22 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id b29sm69161896pfr.159.2019.07.22.10.14.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jul 2019 10:14:21 -0700 (PDT) Date: Mon, 22 Jul 2019 10:14:18 -0700 From: Matthias Kaehlcke To: Rob Herring Cc: Florian Fainelli , "David S . Miller" , Mark Rutland , Andrew Lunn , Heiner Kallweit , netdev , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Douglas Anderson Subject: Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode Message-ID: <20190722171418.GV250418@google.com> References: <20190703193724.246854-1-mka@chromium.org> <20190703193724.246854-6-mka@chromium.org> <20190703232331.GL250418@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 10, 2019 at 09:55:12AM -0600, Rob Herring wrote: > On Wed, Jul 3, 2019 at 5:23 PM Matthias Kaehlcke wrote: > > > > Hi Florian, > > > > On Wed, Jul 03, 2019 at 02:37:47PM -0700, Florian Fainelli wrote: > > > On 7/3/19 12:37 PM, Matthias Kaehlcke wrote: > > > > The LED behavior of some Realtek PHYs is configurable. Add the > > > > property 'realtek,led-modes' to specify the configuration of the > > > > LEDs. > > > > > > > > Signed-off-by: Matthias Kaehlcke > > > > --- > > > > Changes in v2: > > > > - patch added to the series > > > > --- > > > > .../devicetree/bindings/net/realtek.txt | 9 +++++++++ > > > > include/dt-bindings/net/realtek.h | 17 +++++++++++++++++ > > > > 2 files changed, 26 insertions(+) > > > > create mode 100644 include/dt-bindings/net/realtek.h > > > > > > > > diff --git a/Documentation/devicetree/bindings/net/realtek.txt b/Documentation/devicetree/bindings/net/realtek.txt > > > > index 71d386c78269..40b0d6f9ee21 100644 > > > > --- a/Documentation/devicetree/bindings/net/realtek.txt > > > > +++ b/Documentation/devicetree/bindings/net/realtek.txt > > > > @@ -9,6 +9,12 @@ Optional properties: > > > > > > > > SSC is only available on some Realtek PHYs (e.g. RTL8211E). > > > > > > > > +- realtek,led-modes: LED mode configuration. > > > > + > > > > + A 0..3 element vector, with each element configuring the operating > > > > + mode of an LED. Omitted LEDs are turned off. Allowed values are > > > > + defined in "include/dt-bindings/net/realtek.h". > > > > > > This should probably be made more general and we should define LED modes > > > that makes sense regardless of the PHY device, introduce a set of > > > generic functions for validating and then add new function pointer for > > > setting the LED configuration to the PHY driver. This would allow to be > > > more future proof where each PHY driver could expose standard LEDs class > > > devices to user-space, and it would also allow facilities like: ethtool > > > -p to plug into that. > > > > > > Right now, each driver invents its own way of configuring LEDs, that > > > does not scale, and there is not really a good reason for that other > > > than reviewing drivers in isolation and therefore making it harder to > > > extract the commonality. Yes, I realize that since you are the latest > > > person submitting something in that area, you are being selected :) > > I agree. > > > I see the merit of your proposal to come up with a generic mechanism > > to configure Ethernet LEDs, however I can't justify spending much of > > my work time on this. If it is deemed useful I'm happy to send another > > version of the current patchset that addresses the reviewer's comments, > > but if the implementation of a generic LED configuration interface is > > a requirement I will have to abandon at least the LED configuration > > part of this series. > > Can you at least define a common binding for this. Maybe that's just > removing 'realtek'. While the kernel side can evolve to a common > infrastructure, the DT bindings can't. I'm working on a generic binding. I wonder what is the best process for reviewing/landing it, I'm doubting between two options: a) only post the binding doc and the generic PHY code that reads the configuration from the DT. Post Realtek patches once the binding/generic code has been acked. pros: no churn from Realtek specific patches cons: initially no (real) user of the new binding b) post generic and Realtek changes together pros: the binding has a user initially cons: churn from Realtek specific patches I can do either, depending on what maintainers/reviewers prefer. I'm slightly inclined towards a)