Re: [PATCH V4 1/2] dt-bindings: reset: imx7: Add support for i.MX8MM

Shawn Guo
2019-07-23T02:59:50Z

On Fri, Jul 05, 2019 at 04:54:05PM +0800, Anson.Huang@nxp.com wrote:
> From: Anson Huang <Anson.Huang@nxp.com>
>
> i.MX8MM can reuse i.MX8MQ's reset driver, update the compatible
> property and related info to support i.MX8MM.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Hi Philipp,

Let me know if you want me to pick this up.

Shawn

> ---
> Changes since V3:
> - Add comments to those reset indices to indicate which are NOT supported on i.MX8MM.
> ---
> .../devicetree/bindings/reset/fsl,imx7-src.txt | 6 +++--
> include/dt-bindings/reset/imx8mq-reset.h | 28 +++++++++++-----------
> 2 files changed, 18 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> index 13e0951..c2489e4 100644
> --- a/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> +++ b/Documentation/devicetree/bindings/reset/fsl,imx7-src.txt
> @@ -8,6 +8,7 @@ Required properties:
> - compatible:
> - For i.MX7 SoCs should be "fsl,imx7d-src", "syscon"
> - For i.MX8MQ SoCs should be "fsl,imx8mq-src", "syscon"
> + - For i.MX8MM SoCs should be "fsl,imx8mm-src", "fsl,imx8mq-src", "syscon"
> - reg: should be register base and length as documented in the
> datasheet
> - interrupts: Should contain SRC interrupt
> @@ -46,5 +47,6 @@ Example:
>
>
> For list of all valid reset indices see
> -<dt-bindings/reset/imx7-reset.h> for i.MX7 and
> -<dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ
> +<dt-bindings/reset/imx7-reset.h> for i.MX7,
> +<dt-bindings/reset/imx8mq-reset.h> for i.MX8MQ and
> +<dt-bindings/reset/imx8mq-reset.h> for i.MX8MM
> diff --git a/include/dt-bindings/reset/imx8mq-reset.h b/include/dt-bindings/reset/imx8mq-reset.h
> index 57c5924..f17ef2a 100644
> --- a/include/dt-bindings/reset/imx8mq-reset.h
> +++ b/include/dt-bindings/reset/imx8mq-reset.h
> @@ -38,26 +38,26 @@
> #define IMX8MQ_RESET_PCIEPHY_PERST 27
> #define IMX8MQ_RESET_PCIE_CTRL_APPS_EN 28
> #define IMX8MQ_RESET_PCIE_CTRL_APPS_TURNOFF 29
> -#define IMX8MQ_RESET_HDMI_PHY_APB_RESET 30
> +#define IMX8MQ_RESET_HDMI_PHY_APB_RESET 30 /* i.MX8MM does NOT support */
> #define IMX8MQ_RESET_DISP_RESET 31
> #define IMX8MQ_RESET_GPU_RESET 32
> #define IMX8MQ_RESET_VPU_RESET 33
> -#define IMX8MQ_RESET_PCIEPHY2 34
> -#define IMX8MQ_RESET_PCIEPHY2_PERST 35
> -#define IMX8MQ_RESET_PCIE2_CTRL_APPS_EN 36
> -#define IMX8MQ_RESET_PCIE2_CTRL_APPS_TURNOFF 37
> -#define IMX8MQ_RESET_MIPI_CSI1_CORE_RESET 38
> -#define IMX8MQ_RESET_MIPI_CSI1_PHY_REF_RESET 39
> -#define IMX8MQ_RESET_MIPI_CSI1_ESC_RESET 40
> -#define IMX8MQ_RESET_MIPI_CSI2_CORE_RESET 41
> -#define IMX8MQ_RESET_MIPI_CSI2_PHY_REF_RESET 42
> -#define IMX8MQ_RESET_MIPI_CSI2_ESC_RESET 43
> +#define IMX8MQ_RESET_PCIEPHY2 34 /* i.MX8MM does NOT support */
> +#define IMX8MQ_RESET_PCIEPHY2_PERST 35 /* i.MX8MM does NOT support */
> +#define IMX8MQ_RESET_PCIE2_CTRL_APPS_EN 36 /* i.MX8MM does NOT support */
> +#define IMX8MQ_RESET_PCIE2_CTRL_APPS_TURNOFF 37 /* i.MX8MM does NOT support */
> +#define IMX8MQ_RESET_MIPI_CSI1_CORE_RESET 38 /* i.MX8MM does NOT support */
> +#define IMX8MQ_RESET_MIPI_CSI1_PHY_REF_RESET 39 /* i.MX8MM does NOT support */
> +#define IMX8MQ_RESET_MIPI_CSI1_ESC_RESET 40 /* i.MX8MM does NOT support */
> +#define IMX8MQ_RESET_MIPI_CSI2_CORE_RESET 41 /* i.MX8MM does NOT support */
> +#define IMX8MQ_RESET_MIPI_CSI2_PHY_REF_RESET 42 /* i.MX8MM does NOT support */
> +#define IMX8MQ_RESET_MIPI_CSI2_ESC_RESET 43 /* i.MX8MM does NOT support */
> #define IMX8MQ_RESET_DDRC1_PRST 44
> #define IMX8MQ_RESET_DDRC1_CORE_RESET 45
> #define IMX8MQ_RESET_DDRC1_PHY_RESET 46
> -#define IMX8MQ_RESET_DDRC2_PRST 47
> -#define IMX8MQ_RESET_DDRC2_CORE_RESET 48
> -#define IMX8MQ_RESET_DDRC2_PHY_RESET 49
> +#define IMX8MQ_RESET_DDRC2_PRST 47 /* i.MX8MM does NOT support */
> +#define IMX8MQ_RESET_DDRC2_CORE_RESET 48 /* i.MX8MM does NOT support */
> +#define IMX8MQ_RESET_DDRC2_PHY_RESET 49 /* i.MX8MM does NOT support */
>
> #define IMX8MQ_RESET_NUM 50
>
> --
> 2.7.4
>