From: Peter Zijlstra <peterz@infradead.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Lockdep: Reduce stack trace memory usage
Date: Tue, 23 Jul 2019 11:27:14 +0200 [thread overview]
Message-ID: <20190723092714.GA3402@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190722182443.216015-1-bvanassche@acm.org>
On Mon, Jul 22, 2019 at 11:24:39AM -0700, Bart Van Assche wrote:
> Hi Peter,
>
> An unfortunate side effect of commit 669de8bda87b ("kernel/workqueue: Use
> dynamic lockdep keys for workqueues") is that all stack traces associated
> with the lockdep key are leaked when a workqueue is destroyed. Fix this by
> storing each unique stack trace once. Please consider this patch series
> for Linux kernel v5.4.
>
> Thanks,
>
> Bart.
>
> Bart Van Assche (4):
> locking/lockdep: Make it clear that what lock_class::key points at is
> not modified
> stacktrace: Constify 'entries' arguments
> locking/lockdep: Reduce space occupied by stack traces
> locking/lockdep: Report more stack trace statistics
>
> include/linux/lockdep.h | 11 +-
> include/linux/stacktrace.h | 4 +-
> kernel/locking/lockdep.c | 159 ++++++++++++++++++++++-------
> kernel/locking/lockdep_internals.h | 9 +-
> kernel/locking/lockdep_proc.c | 8 +-
> kernel/stacktrace.c | 4 +-
> 6 files changed, 143 insertions(+), 52 deletions(-)
Thanks a lot for doing this Bart, excellent stuff!
prev parent reply other threads:[~2019-07-23 9:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 18:24 [PATCH 0/4] Lockdep: Reduce stack trace memory usage Bart Van Assche
2019-07-22 18:24 ` [PATCH 1/4] locking/lockdep: Make it clear that what lock_class::key points at is not modified Bart Van Assche
2019-07-25 16:08 ` [tip:locking/core] " tip-bot for Bart Van Assche
2019-07-22 18:24 ` [PATCH 2/4] stacktrace: Constify 'entries' arguments Bart Van Assche
2019-07-25 16:09 ` [tip:locking/core] " tip-bot for Bart Van Assche
2019-07-22 18:24 ` [PATCH 3/4] locking/lockdep: Reduce space occupied by stack traces Bart Van Assche
2019-07-24 4:56 ` Eric Biggers
2019-07-24 15:47 ` Bart Van Assche
2019-07-25 16:10 ` [tip:locking/core] " tip-bot for Bart Van Assche
2019-07-22 18:24 ` [PATCH 4/4] locking/lockdep: Report more stack trace statistics Bart Van Assche
2019-07-25 16:10 ` [tip:locking/core] " tip-bot for Bart Van Assche
2019-07-23 9:27 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723092714.GA3402@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox