public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nikolas Nyby <nikolas@gnu.org>
To: tglx@linutronix.de, x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Nikolas Nyby <nikolas@gnu.org>
Subject: [PATCH] x86/crash: remove unnecessary comparison
Date: Wed, 24 Jul 2019 00:13:37 -0400	[thread overview]
Message-ID: <20190724041337.8346-1-nikolas@gnu.org> (raw)

This ret comparison and return are unnecessary as of
f296f2634920d205b93d878b48d87bb7e0a4c256

elf_header_exclude_ranges() returns ret in any case, with or
without this comparison.

Signed-off-by: Nikolas Nyby <nikolas@gnu.org>
---
 arch/x86/kernel/crash.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index 2bf70a2fed90..eb651fbde92a 100644
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -225,8 +225,6 @@ static int elf_header_exclude_ranges(struct crash_mem *cmem)
 	if (crashk_low_res.end) {
 		ret = crash_exclude_mem_range(cmem, crashk_low_res.start,
 							crashk_low_res.end);
-		if (ret)
-			return ret;
 	}
 
 	return ret;
-- 
2.20.1


             reply	other threads:[~2019-07-24  4:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24  4:13 Nikolas Nyby [this message]
2019-07-24 14:55 ` [tip:x86/cleanups] x86/crash: Remove unnecessary comparison tip-bot for Nikolas Nyby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190724041337.8346-1-nikolas@gnu.org \
    --to=nikolas@gnu.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox