From: Kelsey Skunberg <skunberg.kelsey@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: iyappan@os.amperecomputing.com, keyur@os.amperecomputing.com,
quan@os.amperecomputing.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bjorn@helgaas.com,
skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls
Date: Tue, 23 Jul 2019 23:56:44 -0600 [thread overview]
Message-ID: <20190724055644.GA103525@JATN> (raw)
In-Reply-To: <20190723.140739.379654507424022463.davem@davemloft.net>
On Tue, Jul 23, 2019 at 02:07:39PM -0700, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 23 Jul 2019 14:06:46 -0700 (PDT)
>
> > From: Kelsey Skunberg <skunberg.kelsey@gmail.com>
> > Date: Tue, 23 Jul 2019 12:58:11 -0600
> >
> >> acpi_evaluate_object will already return an error if the needed method
> >> does not exist. Remove unnecessary acpi_has_method() calls and check the
> >> returned acpi_status for failure instead.
> >>
> >> Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
> >> ---
> >> Changes in v2:
> >> - Fixed white space warnings and errors
> >
> > Applied to net-next.
>
> Wow did you even build test this? Reverted...
>
This patch has definitely been a mess, so thank you for your time and
sticking with me here. I thought my build tests included these files,
though discovered they did not. Since submitting v2, I was able to reproduce the
same errors you listed and corrected the problem in v3.
I also realized my .git/post-commit file needed to be fixed, so the white
space problem in v1 should also not be a problem in the future.
Please let me know if you notice anything else I can improve on. I will
learn from my mistakes and really appreciate advice. Thank you again, David.
Best Regards,
Kelsey
next prev parent reply other threads:[~2019-07-24 5:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 3:04 [PATCH] drivers: net: xgene: Remove acpi_has_method() calls Kelsey Skunberg
2019-07-22 11:05 ` kbuild test robot
2019-07-23 1:17 ` David Miller
2019-07-23 18:58 ` [PATCH v2] " Kelsey Skunberg
2019-07-23 21:06 ` David Miller
2019-07-23 21:07 ` David Miller
2019-07-24 5:56 ` Kelsey Skunberg [this message]
2019-07-23 22:56 ` Bjorn Helgaas
2019-07-23 23:17 ` Kelsey Skunberg
2019-07-24 6:06 ` [PATCH v3] " Kelsey Skunberg
2019-07-24 18:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724055644.GA103525@JATN \
--to=skunberg.kelsey@gmail.com \
--cc=bjorn@helgaas.com \
--cc=davem@davemloft.net \
--cc=iyappan@os.amperecomputing.com \
--cc=keyur@os.amperecomputing.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quan@os.amperecomputing.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox