From: Jason Gunthorpe <jgg@ziepe.ca>
To: YueHaibing <yuehaibing@huawei.com>
Cc: oulijun@huawei.com, xavier.huwei@huawei.com, dledford@redhat.com,
leon@kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/hns: Fix build error
Date: Wed, 24 Jul 2019 08:32:52 -0300 [thread overview]
Message-ID: <20190724113252.GA28493@ziepe.ca> (raw)
In-Reply-To: <20190724065443.53068-1-yuehaibing@huawei.com>
On Wed, Jul 24, 2019 at 02:54:43PM +0800, YueHaibing wrote:
> If INFINIBAND_HNS_HIP08 is selected and HNS3 is m,
> but INFINIBAND_HNS is y, building fails:
>
> drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_exit':
> hns_roce_hw_v2.c:(.exit.text+0xd): undefined reference to `hnae3_unregister_client'
> drivers/infiniband/hw/hns/hns_roce_hw_v2.o: In function `hns_roce_hw_v2_init':
> hns_roce_hw_v2.c:(.init.text+0xd): undefined reference to `hnae3_register_client'
>
> Also if INFINIBAND_HNS_HIP06 is selected and HNS_DSAF
> is m, but INFINIBAND_HNS is y, building fails:
>
> drivers/infiniband/hw/hns/hns_roce_hw_v1.o: In function `hns_roce_v1_reset':
> hns_roce_hw_v1.c:(.text+0x39fa): undefined reference to `hns_dsaf_roce_reset'
> hns_roce_hw_v1.c:(.text+0x3a25): undefined reference to `hns_dsaf_roce_reset'
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: dd74282df573 ("RDMA/hns: Initialize the PCI device for hip08 RoCE")
> Fixes: 08805fdbeb2d ("RDMA/hns: Split hw v1 driver from hns roce driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> drivers/infiniband/hw/hns/Kconfig | 6 +++---
> drivers/infiniband/hw/hns/Makefile | 8 ++------
> 2 files changed, 5 insertions(+), 9 deletions(-)
did you test this approach with CONFIG_MODULES=n?
Jason
next prev parent reply other threads:[~2019-07-24 11:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 2:49 [PATCH] RDMA/hns: Fix build error for hip08 YueHaibing
2019-07-23 7:43 ` Leon Romanovsky
2019-07-23 10:06 ` Yuehaibing
2019-07-23 10:17 ` Leon Romanovsky
2019-07-23 12:34 ` Jason Gunthorpe
2019-07-23 13:35 ` Leon Romanovsky
2019-07-23 13:37 ` Jason Gunthorpe
2019-07-24 3:10 ` Yuehaibing
2019-07-24 3:40 ` [PATCH v2] " YueHaibing
2019-07-24 6:12 ` Yuehaibing
2019-07-24 6:54 ` [PATCH] RDMA/hns: Fix build error YueHaibing
2019-07-24 11:32 ` Jason Gunthorpe [this message]
2019-07-24 11:47 ` Yuehaibing
2019-07-29 16:05 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724113252.GA28493@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=oulijun@huawei.com \
--cc=xavier.huwei@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox