From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BD2C76186 for ; Wed, 24 Jul 2019 17:41:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6CF72184B for ; Wed, 24 Jul 2019 17:41:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563990094; bh=D4bE665nM5LzWcaA4zQvt4ZilfR5RBc9ne4A65LT40E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=u+XJ+igO67WpZ3undhHWzfQ+uYT8yFfNZTPxRwYRfqUej9mmCRWc+ST9Uma0k6Me3 bJwITUOp6bxSMN8bNsoMnrMV1/xWJ+V0V15U+SPyt+kvModCleqyT6nzfWoIrtNr1q Wxr6KGgguT7tv5DRILMv/noAbrST/VSexvVZuy7k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387549AbfGXRld (ORCPT ); Wed, 24 Jul 2019 13:41:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:38416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726323AbfGXRld (ORCPT ); Wed, 24 Jul 2019 13:41:33 -0400 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69D782184B; Wed, 24 Jul 2019 17:41:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563990091; bh=D4bE665nM5LzWcaA4zQvt4ZilfR5RBc9ne4A65LT40E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t3RZcZtsAIaY8XJWpTiq9Gg0sVvqR/5lWoO/5beJQ6sAXhWbWcE7okoi/rDg9cAbw zAdLqiBqnnEwHxJfwW6+tFDsLAuZ/gwWIaFMYb7wP2TNB4CR17FVYMLRPUluzpultO ciyDP2bElxavp3s70irEN6KalhwNoy2ldGpausrI= Date: Wed, 24 Jul 2019 10:41:29 -0700 From: Eric Biggers To: Tejun Heo , Michael Bringmann Cc: Dmitry Vyukov , syzbot , Lai Jiangshan , LKML , syzkaller-bugs Subject: Re: linux-next boot error: WARNING: workqueue cpumask: online intersect > possible intersect Message-ID: <20190724174129.GE213255@gmail.com> Mail-Followup-To: Tejun Heo , Michael Bringmann , Dmitry Vyukov , syzbot , Lai Jiangshan , LKML , syzkaller-bugs References: <000000000000f19676058ab7adc4@google.com> <20190611185206.GG3341036@devbig004.ftw2.facebook.com> <20190723163126.GB23641@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190723163126.GB23641@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 23, 2019 at 09:31:27AM -0700, Eric Biggers wrote: > On Tue, Jul 23, 2019 at 10:16:24AM +0200, 'Dmitry Vyukov' via syzkaller-bugs wrote: > > On Tue, Jun 11, 2019 at 8:52 PM Tejun Heo wrote: > > > > > > Hello, > > > > > > On Fri, Jun 07, 2019 at 10:45:45AM +0200, Dmitry Vyukov wrote: > > > > +workqueue maintainers and Michael who added this WARNING > > > > > > > > The WARNING was added in 2017, so I guess it's a change somewhere else > > > > that triggered it. > > > > The WARNING message does not seem to give enough info about the caller > > > > (should it be changed to WARN_ONCE to print a stack?). How can be root > > > > cause this and unbreak linux-next? > > > > > > So, during boot, workqueue builds masks of possible cpus of each node > > > and stores them on wq_numa_possible_cpumask[] array. The warning is > > > saying that somehow online cpumask of a node became a superset of the > > > possible mask, which should never happen. > > > > > > Dumping all masks in wq_numa_possible_cpumasks[] and cpumask_of_node() > > > of each node should show what's going on. > > > > This has reached upstream and all subsystem subtrees, now all Linux > > trees are boot broken (except for few that still lack behind): > > https://syzkaller.appspot.com/upstream > > > > No new Linux code is tested by syzbot at this point. > > > > AFAICS, what's actually happening is that the boot fails due to a different bug, > "general protection fault in dma_direct_max_mapping_size" -- which is a real > boot error, not just a warning; see > https://lkml.kernel.org/lkml/20190723161425.GA23641@gmail.com/ > > syzbot then sees "WARNING: workqueue cpumask: online intersect > possible > intersect" in the console output prior to that, and uses that as the bug title. > > It's not obvious that syzbot would report "WARNING: workqueue cpumask: online > intersect > possible intersect" without the real boot error too. > > Nevertheless the issue is still there and something needs to be done about it. > The real boot error "general protection fault in dma_direct_max_mapping_size" is fixed in mainline now. I believe that unblocks syzbot testing, since it doesn't appear to have been blocked by "WARNING: workqueue cpumask: online intersect > possible intersect" by itself. Anyway: Tejun and Michael, any other ideas for why "WARNING: workqueue cpumask: online intersect > possible intersect" is still happening? - Eric