From: Vasyl Gomonovych <gomonovych@gmail.com>
To: myungjoo.ham@samsung.com, cw00.choi@samsung.com
Cc: Vasyl Gomonovych <gomonovych@gmail.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] extcon: max8997: Use irq mask IRQF_ONESHOT
Date: Thu, 25 Jul 2019 08:43:34 +0200 [thread overview]
Message-ID: <20190725064334.6550-1-gomonovych@gmail.com> (raw)
Do not fire irq again until thread done
This issue was found by code inspection
Coccicheck irqf_oneshot.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/extcon/extcon-max8997.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index 172e116ac1ce..c347365242d2 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -660,7 +660,7 @@ static int max8997_muic_probe(struct platform_device *pdev)
ret = request_threaded_irq(virq, NULL,
max8997_muic_irq_handler,
- IRQF_NO_SUSPEND,
+ IRQF_NO_SUSPEND | IRQF_ONESHOT,
muic_irq->name, info);
if (ret) {
dev_err(&pdev->dev,
--
2.17.1
reply other threads:[~2019-07-25 6:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725064334.6550-1-gomonovych@gmail.com \
--to=gomonovych@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox